Skip to content

Commit 565a2b9

Browse files
committed
Merge pull request #189 from rails/test-3-0-beta
Testing 3.0 beta on 2.x
2 parents 85ab602 + 754a91c commit 565a2b9

File tree

4 files changed

+31
-4
lines changed

4 files changed

+31
-4
lines changed

.travis.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ gemfile:
1414
- test/gemfiles/Gemfile.sprockets-2.11.x
1515
- test/gemfiles/Gemfile.sprockets-2.12.x
1616
- test/gemfiles/Gemfile.sprockets-2.8.x
17+
- test/gemfiles/Gemfile.sprockets-3.0.x
1718

1819
env:
1920
- LEGACY=true
@@ -33,6 +34,8 @@ matrix:
3334
rvm: 1.8.7
3435
- gemfile: test/gemfiles/Gemfile.sprockets-2.8.x
3536
rvm: 1.8.7
37+
- gemfile: test/gemfiles/Gemfile.sprockets-3.0.x
38+
rvm: 1.8.7
3639
- gemfile: Gemfile
3740
env: LEGACY=true
3841
- gemfile: test/gemfiles/Gemfile.rails-4.0.x
@@ -45,6 +48,8 @@ matrix:
4548
env: LEGACY=true
4649
- gemfile: test/gemfiles/Gemfile.sprockets-2.8.x
4750
env: LEGACY=true
51+
- gemfile: test/gemfiles/Gemfile.sprockets-3.0.x
52+
env: LEGACY=true
4853
- gemfile: test/gemfiles/Gemfile.rails-3.0.x
4954
env: LEGACY=false
5055
- gemfile: test/gemfiles/Gemfile.rails-3.1.x

sprockets-rails.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ Gem::Specification.new do |s|
1111
s.add_dependency "sprockets", [">= 2.8", "< 4.0"]
1212
s.add_dependency "actionpack", ">= 3.0"
1313
s.add_dependency "activesupport", ">= 3.0"
14-
s.add_development_dependency "rake"
1514
s.add_development_dependency "railties", ">= 3.0"
15+
s.add_development_dependency "rake"
16+
s.add_development_dependency "sass"
17+
s.add_development_dependency "uglifier"
1618

1719
s.author = "Joshua Peek"
1820
s.email = "[email protected]"

test/gemfiles/Gemfile.sprockets-3.0.x

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
source 'https://rubygems.org'
2+
gemspec :path => "./../.."
3+
4+
gem 'sprockets', '3.0.0.beta.4'
5+
6+
gem 'actionpack'
7+
gem 'railties'
8+
9+
gem 'minitest', '= 4.7.3'

test/test_helper.rb

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -525,11 +525,22 @@ def test_non_javascripts_and_stylesheets
525525

526526
class AutomaticDependenciesFromHelpersTest < HelperTest
527527
def test_dependency_added
528-
assert_equal ["logo.png", "url.css.erb"], @assets['url.css'].send(:dependency_paths).map {|d| File.basename(d.pathname) }.sort
528+
asset = @assets['url.css']
529+
if asset.respond_to?(:metadata)
530+
paths = asset.metadata[:dependency_paths].map { |p| File.basename(p) }.sort
531+
else
532+
paths = asset.send(:dependency_paths).map {|d| File.basename(d.pathname) }.sort
533+
end
534+
assert_equal ["logo.png", "url.css.erb"], paths
529535
end
530536

531537
def test_ignores_missing_dependencies
532-
assert_equal ["missing.css.erb"], @assets['error/missing.css'].send(:dependency_paths).map {|d| File.basename(d.pathname) }.sort
538+
asset = @assets['error/missing.css']
539+
if asset.respond_to?(:metadata)
540+
paths = asset.metadata[:dependency_paths].map { |p| File.basename(p) }.sort
541+
else
542+
paths = asset.send(:dependency_paths).map {|d| File.basename(d.pathname) }.sort
543+
end
544+
assert_equal ["missing.css.erb"], paths
533545
end
534-
535546
end

0 commit comments

Comments
 (0)