Merge pull request #241 from rails/detect-asset-alias

Prevent alias logical paths passed to asset_path

Author: josh

lib/sprockets/rails/helper.rb

@@ -15,6 +15,15 @@ def initialize(source)
         end
       end
 
+      class AssetAliasUsed < StandardError
+        def initialize(actual, expected)
+          msg = "Asset was linked to from an alias rather than its exact path. " +
+                "Alias resolving may not be available in production.\n" +
+                "Use #{expected.inspect} instead of #{actual.inspect}"
+          super(msg)
+        end
+      end
+
       include ActionView::Helpers::AssetUrlHelper
       include ActionView::Helpers::AssetTagHelper
 
@@ -80,6 +89,10 @@ def asset_digest_path(path, options = {})
         if environment = assets_environment
           if asset = environment[path]
             unless options[:debug]
+              if path != asset.logical_path
+                raise AssetAliasUsed.new(path, asset.logical_path)
+              end
+
               if !precompiled_assets.include?(asset)
                 raise AssetNotPrecompiled.new(asset.logical_path)
               end

test/fixtures/bundle/index.js

@@ -0,0 +1 @@
+var jQuery;

test/fixtures/jquery/bower.json

@@ -0,0 +1,4 @@
+{
+  "name": "jquery",
+  "main": "./jquery.js"
+}

test/fixtures/jquery/jquery.js

@@ -0,0 +1 @@
+var jQuery;

test/test_helper.rb

@@ -664,6 +664,26 @@ def test_precompile_allows_links
     end
   end
 
+  def test_asset_path_with_index_requires_exact_logical_path
+    @view.assets_precompile = ["bundle.js"]
+
+    assert @view.asset_path("bundle.js")
+
+    assert_raises(Sprockets::Rails::Helper::AssetAliasUsed) do
+      assert @view.asset_path("bundle/index.js")
+    end
+  end
+
+  def test_asset_path_with_bower_requires_exact_logical_path
+    @view.assets_precompile = ["jquery/jquery.js"]
+
+    assert @view.asset_path("jquery/jquery.js")
+
+    assert_raises(Sprockets::Rails::Helper::AssetAliasUsed) do
+      assert @view.asset_path("jquery.js")
+    end
+  end
+
   def test_links_image_target
     assert_match "logo.png", @assets['url.css'].links.to_a[0]
   end