Skip to content

Commit d9acf08

Browse files
committed
Merge pull request #120 from schneems/schneems/fix-configurable
[fixes #119] Remove Configurable usage
2 parents 8bf70f6 + 59e388f commit d9acf08

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

lib/sprockets/rails/helper.rb

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,21 @@
55
module Sprockets
66
module Rails
77
module Helper
8-
# support for Ruby 1.9.3 && Rails 3.0.x
9-
@_config = ActiveSupport::InheritableOptions.new({}) unless defined?(ActiveSupport::Configurable::Configuration)
10-
include ActiveSupport::Configurable
11-
config_accessor :precompile, :assets, :raise_runtime_errors
8+
class << self
9+
attr_accessor :precompile, :assets, :raise_runtime_errors
10+
end
11+
12+
def precompile
13+
Sprockets::Rails::Helper.precompile
14+
end
15+
16+
def assets
17+
Sprockets::Rails::Helper.assets
18+
end
19+
20+
def raise_runtime_errors
21+
Sprockets::Rails::Helper.raise_runtime_errors
22+
end
1223

1324
class DependencyError < StandardError
1425
def initialize(path, dep)

test/test_helper.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,8 @@ def test_stylesheet_path
373373
end
374374

375375
def test_public_folder_fallback_works_correctly
376-
@view.raise_runtime_errors = true
377-
@view.debug_assets = true
376+
Sprockets::Rails::Helper.raise_runtime_errors = true
377+
@view.debug_assets = true
378378

379379
@view.asset_path("asset-does-not-exist-foo.js")
380380
@view.asset_url("asset-does-not-exist-foo.js")
@@ -383,8 +383,8 @@ def test_public_folder_fallback_works_correctly
383383
end
384384

385385
def test_asset_not_precompiled_error
386-
@view.raise_runtime_errors = true
387-
@view.precompile = [ lambda {|logical_path| false } ]
386+
Sprockets::Rails::Helper.raise_runtime_errors = true
387+
Sprockets::Rails::Helper.precompile = [ lambda {|logical_path| false } ]
388388
@view.assets_environment = @assets
389389
@view.debug_assets = true
390390

@@ -412,7 +412,7 @@ def test_asset_not_precompiled_error
412412
@view.stylesheet_link_tag("foo.js")
413413
end
414414

415-
@view.precompile = [ lambda {|logical_path| true } ]
415+
Sprockets::Rails::Helper.precompile = [ lambda {|logical_path| true } ]
416416

417417
@view.asset_path("foo.js")
418418
@view.asset_url("foo.js")
@@ -436,15 +436,15 @@ def test_asset_digest
436436
class ErrorsInHelpersTest < HelperTest
437437

438438
def test_dependency_error
439-
@view.raise_runtime_errors = true
440-
@view.precompile = [ lambda {|logical_path| true } ]
441-
@view.assets_environment = @assets
439+
Sprockets::Rails::Helper.raise_runtime_errors = true
440+
Sprockets::Rails::Helper.precompile = [ lambda {|logical_path| true } ]
441+
@view.assets_environment = @assets
442442

443443
assert_raise Sprockets::Rails::Helper::DependencyError do
444444
@view.asset_path("error/dependency.js")
445445
end
446446

447-
@view.raise_runtime_errors = false
447+
Sprockets::Rails::Helper.raise_runtime_errors = false
448448
@view.asset_path("error/dependency.js")
449449
end
450450
end

0 commit comments

Comments
 (0)