Replace should_receive with expect...to receive

Author: sferik

spec/actions/create_file_spec.rb

@@ -103,7 +103,7 @@ def silence!
 
         it "shows conflict status to the user" do
           expect(create_file("doc/config.rb")).not_to be_identical
-          $stdin.should_receive(:gets).and_return('s')
+          expect($stdin).to receive(:gets).and_return('s')
           file = File.join(destination_root, 'doc/config.rb')
 
           content = invoke!
@@ -114,21 +114,21 @@ def silence!
 
         it "creates the file if the file collision menu returns true" do
           create_file("doc/config.rb")
-          $stdin.should_receive(:gets).and_return('y')
+          expect($stdin).to receive(:gets).and_return('y')
           expect(invoke!).to match(/force  doc\/config\.rb/)
         end
 
         it "skips the file if the file collision menu returns false" do
           create_file("doc/config.rb")
-          $stdin.should_receive(:gets).and_return('n')
+          expect($stdin).to receive(:gets).and_return('n')
           expect(invoke!).to match(/skip  doc\/config\.rb/)
         end
 
         it "executes the block given to show file content" do
           create_file("doc/config.rb")
-          $stdin.should_receive(:gets).and_return('d')
-          $stdin.should_receive(:gets).and_return('n')
-          @base.shell.should_receive(:system).with(/diff -u/)
+          expect($stdin).to receive(:gets).and_return('d')
+          expect($stdin).to receive(:gets).and_return('n')
+          expect(@base.shell).to receive(:system).with(/diff -u/)
           invoke!
         end
       end

spec/actions/file_manipulation_spec.rb

@@ -29,23 +29,23 @@ def file
 
   describe "#chmod" do
     it "executes the command given" do
-      FileUtils.should_receive(:chmod_R).with(0755, file)
+      expect(FileUtils).to receive(:chmod_R).with(0755, file)
       action :chmod, "foo", 0755
     end
 
     it "does not execute the command if pretending" do
-      FileUtils.should_not_receive(:chmod_R)
+      expect(FileUtils).not_to receive(:chmod_R)
       runner(:pretend => true)
       action :chmod, "foo", 0755
     end
 
     it "logs status" do
-      FileUtils.should_receive(:chmod_R).with(0755, file)
+      expect(FileUtils).to receive(:chmod_R).with(0755, file)
       expect(action(:chmod, "foo", 0755)).to eq("       chmod  foo\n")
     end
 
     it "does not log status if required" do
-      FileUtils.should_receive(:chmod_R).with(0755, file)
+      expect(FileUtils).to receive(:chmod_R).with(0755, file)
       expect(action(:chmod, "foo", 0755, :verbose => false)).to be_empty
     end
   end
@@ -178,7 +178,7 @@ def file
     end
 
     it "converts encoded instructions" do
-      runner.should_receive(:file_name).and_return("rdoc")
+      expect(runner).to receive(:file_name).and_return("rdoc")
       action :template, "doc/%file_name%.rb.tt"
       file = File.join(destination_root, "doc/rdoc.rb")
       expect(File.exists?(file)).to be_true

spec/actions_spec.rb

@@ -216,19 +216,19 @@ def file
 
     it "accepts a URL as the path" do
       @file = "http://gist.github.com/103208.txt"
-      runner.should_receive(:open).with(@file, "Accept" => "application/x-thor-template").and_return(@template)
+      expect(runner).to receive(:open).with(@file, "Accept" => "application/x-thor-template").and_return(@template)
       action(:apply, @file)
     end
 
     it "accepts a secure URL as the path" do
       @file = "https://gist.github.com/103208.txt"
-      runner.should_receive(:open).with(@file, "Accept" => "application/x-thor-template").and_return(@template)
+      expect(runner).to receive(:open).with(@file, "Accept" => "application/x-thor-template").and_return(@template)
       action(:apply, @file)
     end
 
     it "accepts a local file path with spaces" do
       @file = File.expand_path("fixtures/path with spaces", File.dirname(__FILE__))
-      runner.should_receive(:open).with(@file).and_return(@template)
+      expect(runner).to receive(:open).with(@file).and_return(@template)
       action(:apply, @file)
     end
 
@@ -254,7 +254,7 @@ def file
 
   describe "#run" do
     before do
-      runner.should_receive(:system).with("ls")
+      expect(runner).to receive(:system).with("ls")
     end
 
     it "executes the command given" do
@@ -270,15 +270,15 @@ def file
     end
 
     it "accepts a color as status" do
-      runner.shell.should_receive(:say_status).with(:run, 'ls from "."', :yellow)
+      expect(runner.shell).to receive(:say_status).with(:run, 'ls from "."', :yellow)
       action :run, "ls", :verbose => :yellow
     end
   end
 
   describe "#run_ruby_script" do
     before do
       Thor::Util.stub(:ruby_command).and_return("/opt/jruby")
-      runner.should_receive(:system).with("/opt/jruby script.rb")
+      expect(runner).to receive(:system).with("/opt/jruby script.rb")
     end
 
     it "executes the ruby script" do
@@ -296,35 +296,35 @@ def file
 
   describe "#thor" do
     it "executes the thor command" do
-      runner.should_receive(:system).with("thor list")
+      expect(runner).to receive(:system).with("thor list")
       action :thor, :list, :verbose => true
     end
 
     it "converts extra arguments to command arguments" do
-      runner.should_receive(:system).with("thor list foo bar")
+      expect(runner).to receive(:system).with("thor list foo bar")
       action :thor, :list, "foo", "bar"
     end
 
     it "converts options hash to switches" do
-      runner.should_receive(:system).with("thor list foo bar --foo")
+      expect(runner).to receive(:system).with("thor list foo bar --foo")
       action :thor, :list, "foo", "bar", :foo => true
 
-      runner.should_receive(:system).with("thor list --foo 1 2 3")
+      expect(runner).to receive(:system).with("thor list --foo 1 2 3")
       action :thor, :list, :foo => [1,2,3]
     end
 
     it "logs status" do
-      runner.should_receive(:system).with("thor list")
+      expect(runner).to receive(:system).with("thor list")
       expect(action(:thor, :list)).to eq("         run  thor list from \".\"\n")
     end
 
     it "does not log status if required" do
-      runner.should_receive(:system).with("thor list --foo 1 2 3")
+      expect(runner).to receive(:system).with("thor list --foo 1 2 3")
       expect(action(:thor, :list, :foo => [1,2,3], :verbose => false)).to be_empty
     end
 
     it "captures the output when :capture is given" do
-      runner.should_receive(:`).with("thor foo bar")
+      expect(runner).to receive(:`).with("thor foo bar")
       action(:thor, "foo", "bar", :capture => true)
     end
   end

spec/command_spec.rb

@@ -42,7 +42,7 @@ def command(options={})
 
     it "does not invoke an existing method" do
       mock = mock()
-      mock.class.should_receive(:handle_no_command_error).with("to_s")
+      expect(mock.class).to receive(:handle_no_command_error).with("to_s")
       Thor::DynamicCommand.new('to_s').run(mock)
     end
   end
@@ -58,7 +58,7 @@ def command(options={})
   describe "#run" do
     it "runs a command by calling a method in the given instance" do
       mock = mock()
-      mock.should_receive(:can_has).and_return {|*args| args }
+      expect(mock).to receive(:can_has).and_return {|*args| args }
       expect(command.run(mock, [1, 2, 3])).to eq([1, 2, 3])
     end
 

spec/group_spec.rb

@@ -36,7 +36,7 @@
     end
 
     it "invokes help message if any of the shortcuts are given" do
-      MyCounter.should_receive(:help)
+      expect(MyCounter).to receive(:help)
       MyCounter.start(["-h"])
     end
   end

spec/runner_spec.rb

@@ -46,7 +46,7 @@ def when_no_thorfiles_exist
 
     it "raises error if a class/command cannot be found for a setup without thorfiles" do
       when_no_thorfiles_exist do
-        Thor::Runner.should_receive :exit
+        expect(Thor::Runner).to receive :exit
         content = capture(:stderr){ Thor::Runner.start(["help", "unknown"]) }
         expect(content.strip).to eq('Could not find command "unknown".')
       end
@@ -93,7 +93,7 @@ def when_no_thorfiles_exist
     it "raises an error if class/command can't be found in a setup without thorfiles" do
       when_no_thorfiles_exist do
         ARGV.replace ["unknown"]
-        Thor::Runner.should_receive :exit
+        expect(Thor::Runner).to receive :exit
         content = capture(:stderr){ Thor::Runner.start }
         expect(content.strip).to eq('Could not find command "unknown".')
       end
@@ -192,7 +192,7 @@ def when_no_thorfiles_exist
     describe "uninstall" do
       before do
         path = File.join(Thor::Util.thor_root, @original_yaml["random"][:filename])
-        FileUtils.should_receive(:rm_rf).with(path)
+        expect(FileUtils).to receive(:rm_rf).with(path)
       end
 
       it "uninstalls existing thor modules" do
@@ -202,7 +202,7 @@ def when_no_thorfiles_exist
 
     describe "installed" do
       before do
-        Dir.should_receive(:[]).and_return([])
+        expect(Dir).to receive(:[]).and_return([])
       end
 
       it "displays the modules installed in a pretty way" do
@@ -219,15 +219,15 @@ def when_no_thorfiles_exist
         $stdin.stub(:gets).and_return("Y")
 
         path = File.join(Thor::Util.thor_root, Digest::MD5.hexdigest(@location + "random"))
-        File.should_receive(:open).with(path, "w")
+        expect(File).to receive(:open).with(path, "w")
       end
 
       it "updates existing thor files" do
         path = File.join(Thor::Util.thor_root, @original_yaml["random"][:filename])
         if File.directory? path
-          FileUtils.should_receive(:rm_rf).with(path)
+          expect(FileUtils).to receive(:rm_rf).with(path)
         else
-          File.should_receive(:delete).with(path)
+          expect(File).to receive(:delete).with(path)
         end
         silence(:stdout) { Thor::Runner.start(["update", "random"]) }
       end