Skip to content

Commit 2650732

Browse files
committed
Avoid loading bundler 2.4.22 that vendorizes thor 1.3.0
when thor 1.3.0 is vendorized, lcs_diff.rb emits method redefinition warnings as follows: .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:6: warning: method redefined; discarding old show_diff .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:6: warning: previous definition of show_diff was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:21: warning: method redefined; discarding old output_diff_line .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:21: warning: previous definition of output_diff_line was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:37: warning: method redefined; discarding old diff_lcs_loaded? .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:37: warning: previous definition of diff_lcs_loaded? was here
1 parent f1ba900 commit 2650732

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ jobs:
1212
- uses: ruby/setup-ruby@v1
1313
with:
1414
ruby-version: ${{ matrix.ruby }}
15+
bundler: ${{ (matrix.ruby_version < '3' && '2.4.21') || 'lagest' }}
1516
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
1617
- run: bundle exec thor spec

0 commit comments

Comments
 (0)