Merge pull request #456 from dgorst/master

Issue #455 - only allow a hash key to be specified once

Author: sferik

lib/thor/parser/arguments.rb

@@ -99,6 +99,7 @@ def parse_hash(name)
 
       while current_is_value? && peek.include?(":")
         key, value = shift.split(":", 2)
+        fail MalformattedArgumentError, "You can't specify '#{key}' more than once in option '#{name}'; got #{key}:#{hash[key]} and #{key}:#{value}" if hash.include? key
         hash[key] = value
       end
       hash

spec/parser/options_spec.rb

@@ -293,7 +293,7 @@ def remaining
         enum = %w[apple banana]
         create :fruit => Thor::Option.new("fruit", :type => :string, :enum => enum)
         expect { parse("--fruit", "orange") }.to raise_error(Thor::MalformattedArgumentError,
-                                                             "Expected '--fruit' to be one of #{enum.join(', ')}; got orange")
+            "Expected '--fruit' to be one of #{enum.join(', ')}; got orange")
       end
     end
 
@@ -364,6 +364,10 @@ def remaining
       it "must not mix values with other switches" do
         expect(parse("--attributes", "name:string", "age:integer", "--baz", "cool")["attributes"]).to eq("name" => "string", "age" => "integer")
       end
+
+      it "must not allow the same hash key to be specified multiple times" do
+        expect {parse("--attributes", "name:string", "name:integer")}.to raise_error(Thor::MalformattedArgumentError, "You can't specify 'name' more than once in option '--attributes'; got name:string and name:integer")
+      end
     end
 
     describe "with :array type" do