Merge pull request #720 from 2called-chaos/fix-remove-file-unlinks-symlinks

`remove_file` should unlink broken symlinks

Author: rafaelfranca

lib/thor/actions/file_manipulation.rb

@@ -331,7 +331,7 @@ def remove_file(path, config = {})
       path = File.expand_path(path, destination_root)
 
       say_status :remove, relative_to_original_destination_root(path), config.fetch(:verbose, true)
-      if !options[:pretend] && File.exist?(path)
+      if !options[:pretend] && (File.exist?(path) || File.symlink?(path))
         require "fileutils"
         ::FileUtils.rm_rf(path)
       end

spec/actions/file_manipulation_spec.rb

@@ -256,6 +256,13 @@ def file
         expect(File.exist?(file)).to be false
       end
 
+      it "removes broken symlinks too" do
+        link_path = File.join(destination_root, "broken_symlink")
+        ::FileUtils.ln_s("invalid_reference", link_path)
+        action :remove_file, "broken_symlink"
+        expect(File.symlink?(link_path) || File.exist?(link_path)).to be false
+      end
+
       it "removes directories too" do
         action :remove_dir, "doc"
         expect(File.exist?(File.join(destination_root, "doc"))).to be false