Skip to content

Commit 4ee68cb

Browse files
committed
try coveralls_reborn to fix ssl errors.
Note that we could also use the coveralls action as recommended in https://github.com/tagliala/coveralls-ruby-reborn but it seems like a github token is needed, which makes it more complex for contributors This does mean dropping coveralls for EOLed rubies but do we really need to post to coveralls on each test run? Wouldn't one test run be enough?
1 parent 0def4cf commit 4ee68cb

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ end
99

1010
group :test do
1111
gem "childlabor"
12-
gem "coveralls", ">= 0.8.19"
12+
gem 'coveralls_reborn', '~> 0.23.1', require: false if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
1313
gem "rspec", ">= 3.2"
1414
gem "rspec-mocks", ">= 3"
1515
gem "rubocop", "~> 0.50.0"

spec/helper.rb

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
$TESTING = true
22

3-
require "simplecov"
4-
require "coveralls"
3+
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
4+
require "simplecov"
5+
require "coveralls"
56

6-
SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
7+
SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
78

8-
SimpleCov.start do
9-
add_filter "/spec"
10-
minimum_coverage(90)
9+
SimpleCov.start do
10+
add_filter "/spec"
11+
minimum_coverage(90)
12+
end
1113
end
1214

1315
$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))

0 commit comments

Comments
 (0)