Merge pull request #345 from rthbound/patch-8

Patch 8 - Improves on readability of specs

Author: sferik

spec/base_spec.rb

@@ -98,7 +98,7 @@ def hello
   end
 
   describe "#remove_argument" do
-    it "removes previous defined arguments from class" do
+    it "removes previously defined arguments from class" do
       expect(ClearCounter.arguments).to be_empty
     end
 
@@ -119,15 +119,15 @@ def hello
       @content = capture(:stdout) { MyCounter.help(Thor::Base.shell.new) }
     end
 
-    it "shows options description" do
+    it "shows option's description" do
       expect(@content).to match(/# The third argument/)
     end
 
     it "shows usage with banner content" do
       expect(@content).to match(/\[\-\-third=THREE\]/)
     end
 
-    it "shows default values below description" do
+    it "shows default values below descriptions" do
       expect(@content).to match(/# Default: 3/)
     end
 

spec/group_spec.rb

@@ -13,7 +13,7 @@
       expect(MyCounter.start(["1", "2", "--third", "3"])).to eq([ 1, 2, 3, nil, nil, nil ])
     end
 
-    it "uses argument default value" do
+    it "uses argument's default value" do
       expect(MyCounter.start(["1", "--third", "3"])).to eq([ 1, 2, 3, nil, nil, nil ])
     end
 
@@ -35,7 +35,7 @@
       expect{ WhinyGenerator.start }.to raise_error(ArgumentError, /thor wrong_arity takes 1 argument, but it should not/)
     end
 
-    it "invokes help message if any of the shortcuts is given" do
+    it "invokes help message if any of the shortcuts are given" do
       MyCounter.should_receive(:help)
       MyCounter.start(["-h"])
     end

spec/invocation_spec.rb

@@ -76,13 +76,13 @@
       expect(capture(:stdout) { base.invoke("c:one") }).to be_empty
     end
 
-    it "raises Thor::UndefinedcommandError if the command can't be found" do
+    it "raises Thor::UndefinedCommandError if the command can't be found" do
       expect {
         A.new.invoke("foo:bar")
       }.to raise_error(Thor::UndefinedCommandError)
     end
 
-    it "raises Thor::UndefinedcommandError if the command can't be found even if all commands were already executed" do
+    it "raises Thor::UndefinedCommandError if the command can't be found even if all commands were already executed" do
       base = C.new
       silence(:stdout){ base.invoke_all }
 

spec/runner_spec.rb

@@ -28,7 +28,7 @@ def when_no_thorfiles_exist
       expect(content).to match(/zoo\s+# zoo around/m)
     end
 
-    it "shows information about an specific command from an specific Thor class" do
+    it "shows information about a specific command from a specific Thor class" do
       content = capture(:stdout) { Thor::Runner.start(["help", "my_script:zoo"]) }
       expect(content).to match(/zoo around/)
       expect(content).not_to match(/help \[COMMAND\]/)

spec/thor_spec.rb

@@ -164,7 +164,7 @@ def boring(*args)
       expect(MyScript.start(["-T", "fish"])).to eq(["fish"])
     end
 
-    it "calls the alias of a method if several are provided via .map" do
+    it "calls the alias of a method if several are provided via #map" do
       expect(MyScript.start(["-f", "fish"])).to eq(["fish", {}])
       expect(MyScript.start(["--foo", "fish"])).to eq(["fish", {}])
     end
@@ -214,7 +214,7 @@ def boring(*args)
         expect(capture(:stdout) { MyScript.start(["help"]) }).not_to match(/this is hidden/m)
       end
 
-      it "but the command is still invokcable not show the command in help" do
+      it "but the command is still invokable, does not show the command in help" do
         expect(MyScript.start(["hidden", "yesyes"])).to eq(["yesyes"])
       end
     end

spec/util_spec.rb

@@ -124,11 +124,11 @@ def self.clear_user_home!
       Thor::Util.clear_user_home!
     end
 
-    it "returns the user path if none variable is set on the environment" do
+    it "returns the user path if no variable is set on the environment" do
       expect(Thor::Util.user_home).to eq(File.expand_path("~"))
     end
 
-    it "returns the *unix system path if file cannot be expanded and separator does not exist" do
+    it "returns the *nix system path if file cannot be expanded and separator does not exist" do
       File.should_receive(:expand_path).with("~").and_raise(RuntimeError)
       previous_value = File::ALT_SEPARATOR
       capture(:stderr){ File.const_set(:ALT_SEPARATOR, false) }