Merge pull request #369 from sirbrillig/correct_default_on_no

Correct Basic#no? for misc. input

Author: sferik

lib/thor/shell/basic.rb

@@ -112,7 +112,7 @@ def yes?(statement, color=nil)
       # "no".
       #
       def no?(statement, color=nil)
-        !yes?(statement, color)
+        !!(ask(statement, color) =~ is?(:no))
       end
 
       # Prints values in columns

spec/shell/basic_spec.rb

@@ -73,6 +73,12 @@ def shell
         expect($stdin).to receive(:gets).and_return('n')
       expect(shell.yes?("Should I overwrite it?")).not_to be true
     end
+
+    it "asks the user and returns false if the user replies with an answer other than yes or no" do
+      expect($stdout).to receive(:print).with("Should I overwrite it? ")
+        expect($stdin).to receive(:gets).and_return('foobar')
+      expect(shell.yes?("Should I overwrite it?")).to be_false
+    end
   end
 
   describe "#no?" do
@@ -85,6 +91,12 @@ def shell
         expect($stdin).to receive(:gets).and_return('Yes')
       expect(shell.no?("Should I overwrite it?")).to be false
     end
+
+    it "asks the user and returns false if the user replies with an answer other than yes or no" do
+      expect($stdout).to receive(:print).with("Should I overwrite it? ")
+        expect($stdin).to receive(:gets).and_return('foobar')
+      expect(shell.no?("Should I overwrite it?")).to be_false
+    end
   end
 
   describe "#say" do