Skip to content

Commit 688c3f2

Browse files
authored
Merge pull request #611 from bosoxbill/doc-for-cve-2016-10545
Add language about how not to use Thor
2 parents 0ecea7b + 345ee5a commit 688c3f2

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@ utilities. It removes the pain of parsing command line options, writing
1919
build tool. The syntax is Rake-like, so it should be familiar to most Rake
2020
users.
2121

22+
Please note: Thor, by design, is a system tool created to allow seamless file and url
23+
access, which should not receive application user input. It relies on [open-uri][open-uri],
24+
which combined with application user input would provide a command injection attack
25+
vector.
26+
2227
[rake]: https://github.com/ruby/rake
28+
[open-uri]: https://ruby-doc.org/stdlib-2.5.1/libdoc/open-uri/rdoc/index.html
2329

2430
Installation
2531
------------

0 commit comments

Comments
 (0)