Merge pull request #355 from athaeryn/consistency

More consistent punctuation

Author: sferik

lib/thor/base.rb

@@ -474,10 +474,10 @@ def handle_no_command_error(command, has_namespace = $thor_runner) #:nodoc:
       alias handle_no_task_error handle_no_command_error
 
       def handle_argument_error(command, error, args, arity) #:nodoc:
-        msg = "ERROR: #{basename} #{command.name} was called with "
+        msg = "ERROR: \"#{basename} #{command.name}\" was called with "
         msg << 'no arguments'               if  args.empty?
         msg << 'arguments ' << args.inspect if !args.empty?
-        msg << "\nUsage: #{self.banner(command).inspect}."
+        msg << "\nUsage: #{self.banner(command).inspect}"
         raise InvocationError, msg
       end
 

spec/group_spec.rb

@@ -133,7 +133,7 @@
           }
         }
         expect(content).to match(/invoke  e/)
-        expect(error).to match(/ERROR: thor two was called with arguments/)
+        expect(error).to match(/ERROR: "thor two" was called with arguments/)
       end
 
       it "shows invocation information to the user" do

spec/runner_spec.rb

@@ -112,7 +112,7 @@ def when_no_thorfiles_exist
     it "does not swallow Thor InvocationError" do
       ARGV.replace ["my_script:animal"]
       content = capture(:stderr) { Thor::Runner.start }
-      expect(content.strip).to eq(%Q'ERROR: thor animal was called with no arguments\nUsage: "thor my_script:animal TYPE".')
+      expect(content.strip).to eq(%Q'ERROR: "thor animal" was called with no arguments\nUsage: "thor my_script:animal TYPE"')
     end
   end
 

spec/thor_spec.rb

@@ -259,12 +259,12 @@ def boring(*args)
         stderr = capture(:stderr) { Scripts::Arities.start(args) }
         expect(stderr.strip).to eq(msg)
       end
-      arity_asserter.call ["zero_args",    "one"         ], %Q'ERROR: thor zero_args was called with arguments ["one"]\nUsage: "thor scripts:arities:zero_args".'
-      arity_asserter.call ["one_arg"                     ], %Q'ERROR: thor one_arg was called with no arguments\nUsage: "thor scripts:arities:one_arg ARG".'
-      arity_asserter.call ["one_arg",      "one", "two"  ], %Q'ERROR: thor one_arg was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:one_arg ARG".'
-      arity_asserter.call ["one_arg",      "one", "two"  ], %Q'ERROR: thor one_arg was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:one_arg ARG".'
-      arity_asserter.call ["two_args",     "one"         ], %Q'ERROR: thor two_args was called with arguments ["one"]\nUsage: "thor scripts:arities:two_args ARG1 ARG2".'
-      arity_asserter.call ["optional_arg", "one", "two"  ], %Q'ERROR: thor optional_arg was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:optional_arg [ARG]".'
+      arity_asserter.call ["zero_args",    "one"         ], %Q'ERROR: "thor zero_args" was called with arguments ["one"]\nUsage: "thor scripts:arities:zero_args"'
+      arity_asserter.call ["one_arg"                     ], %Q'ERROR: "thor one_arg" was called with no arguments\nUsage: "thor scripts:arities:one_arg ARG"'
+      arity_asserter.call ["one_arg",      "one", "two"  ], %Q'ERROR: "thor one_arg" was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:one_arg ARG"'
+      arity_asserter.call ["one_arg",      "one", "two"  ], %Q'ERROR: "thor one_arg" was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:one_arg ARG"'
+      arity_asserter.call ["two_args",     "one"         ], %Q'ERROR: "thor two_args" was called with arguments ["one"]\nUsage: "thor scripts:arities:two_args ARG1 ARG2"'
+      arity_asserter.call ["optional_arg", "one", "two"  ], %Q'ERROR: "thor optional_arg" was called with arguments ["one", "two"]\nUsage: "thor scripts:arities:optional_arg [ARG]"'
     end
 
     it "raises an error if the invoked command does not exist" do