Merge pull request #452 from bronzle/fix_remove_command

use merge! (with bang) to ensure that cached @all_commands can be modified

Author: sferik

lib/thor/base.rb

@@ -343,7 +343,7 @@ def commands
       #
       def all_commands
         @all_commands ||= from_superclass(:all_commands, Thor::CoreExt::OrderedHash.new)
-        @all_commands.merge(commands)
+        @all_commands.merge!(commands)
       end
       alias_method :all_tasks, :all_commands
 

spec/base_spec.rb

@@ -228,7 +228,7 @@ def hello
 
   describe "#remove_command" do
     it "removes the command from its commands hash" do
-      expect(MyChildScript.commands.keys).not_to include("bar")
+      expect(MyChildScript.all_commands.keys).not_to include("name_with_dashes")
       expect(MyChildScript.commands.keys).not_to include("boom")
     end
 

spec/fixtures/script.thor

@@ -118,7 +118,7 @@ END
 end
 
 class MyChildScript < MyScript
-  remove_command :bar
+  remove_command :name_with_dashes
 
   method_options :force => :boolean, :param => :numeric
   def initialize(*args)