Move :echo => false support into LineEditors

:echo => false was added to the ask method in dbfdd30, this maintains that
behaviour with Readline support.

Tip o' the hat to @cwninja, we paired on this.

Author: georgebrock

lib/thor/line_editor/basic.rb

@@ -14,7 +14,21 @@ def initialize(prompt, options)
 
       def readline
         $stdout.print(prompt)
-        $stdin.gets
+        get_input
+      end
+
+      private
+
+      def get_input
+        if echo?
+          $stdin.gets
+        else
+          $stdin.noecho(&:gets)
+        end
+      end
+
+      def echo?
+        options.fetch(:echo, true)
       end
     end
   end

lib/thor/line_editor/readline.rb

@@ -8,9 +8,13 @@ def self.available?
       end
 
       def readline
-        ::Readline.completion_append_character = nil
-        ::Readline.completion_proc = completion_proc
-        ::Readline.readline(prompt, add_to_history?)
+        if echo?
+          ::Readline.completion_append_character = nil
+          ::Readline.completion_proc = completion_proc
+          ::Readline.readline(prompt, add_to_history?)
+        else
+          super
+        end
       end
 
       private

spec/line_editor/basic_spec.rb

@@ -11,8 +11,18 @@
     it 'uses $stdin and $stdout to get input from the user' do
       expect($stdout).to receive(:print).with('Enter your name ')
       expect($stdin).to receive(:gets).and_return('George')
+      expect($stdin).not_to receive(:noecho)
       editor = Thor::LineEditor::Basic.new('Enter your name ', {})
       expect(editor.readline).to eq('George')
     end
+
+    it 'disables echo when asked to' do
+      expect($stdout).to receive(:print).with('Password: ')
+      noecho_stdin = double('noecho_stdin')
+      expect(noecho_stdin).to receive(:gets).and_return('secret')
+      expect($stdin).to receive(:noecho).and_yield(noecho_stdin)
+      editor = Thor::LineEditor::Basic.new('Password: ', :echo => false)
+      expect(editor.readline).to eq('secret')
+    end
   end
 end

spec/line_editor/readline_spec.rb

@@ -56,5 +56,14 @@
       editor = Thor::LineEditor::Readline.new('Path to file: ', :path => true)
       Dir.chdir(File.dirname(__FILE__)) { editor.readline }
     end
+
+    it 'uses STDIN when asked not to echo input' do
+      expect($stdout).to receive(:print).with('Password: ')
+      noecho_stdin = double('noecho_stdin')
+      expect(noecho_stdin).to receive(:gets).and_return('secret')
+      expect($stdin).to receive(:noecho).and_yield(noecho_stdin)
+      editor = Thor::LineEditor::Readline.new('Password: ', :echo => false)
+      expect(editor.readline).to eq('secret')
+    end
   end
 end