Skip to content

Commit c9e762a

Browse files
committed
Implement suggested changes
1 parent b533e08 commit c9e762a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lib/thor/parser/option.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,12 @@ def aliases_for_usage
105105
end
106106

107107
def show_default?
108-
super || [TrueClass, FalseClass].any? { |c| default.is_a?(c) }
108+
case default
109+
when TrueClass, FalseClass
110+
true
111+
else
112+
super
113+
end
109114
end
110115

111116
VALID_TYPES.each do |type|

spec/parser/option_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,14 @@ def option(name, options = {})
272272

273273
describe "#print_default" do
274274
it "prints boolean with true default value" do
275-
expect(option(:foo, {
275+
expect(option(:foo, {
276276
required: false,
277277
type: :boolean,
278278
default: true
279279
}).print_default).to eq(true)
280280
end
281281
it "prints boolean with false default value" do
282-
expect(option(:foo, {
282+
expect(option(:foo, {
283283
required: false,
284284
type: :boolean,
285285
default: false

0 commit comments

Comments
 (0)