Shell#ask: support a noecho option for stdin

Author: Van Miranda

lib/thor/shell/basic.rb

@@ -1,4 +1,5 @@
 require 'tempfile'
+require 'io/console'
 
 class Thor
   module Shell
@@ -381,7 +382,12 @@ def ask_simply(statement, color, options)
         default = options[:default]
         message = [statement, ("(#{default})" if default), nil].uniq.join(" ")
         say(message, color)
-        result = stdin.gets
+
+        result = if options[:noecho]
+          stdin.noecho(&:gets)
+        else
+          stdin.gets
+        end
 
         return unless result
 

spec/shell/basic_spec.rb

@@ -29,6 +29,11 @@ def shell
       expect(shell.ask("")).to eq(nil)
     end
 
+    it "prints a message to the user and does not echo stdin if the noecho option is set to true" do
+      $stdout.should_receive(:print).with('What\'s your password? ')
+      $stdin.should_receive(:noecho).and_return('mysecretpass')
+      expect(shell.ask("What's your password?", :noecho => true)).to eq("mysecretpass")
+    end
 
     it "prints a message to the user with the available options and determines the correctness of the answer" do
       $stdout.should_receive(:print).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ')