Merge pull request #393 from erikhuda/debug-config

Make possible to pass a debug config to the Base.start

Author: rafaelfranca

lib/thor.rb

@@ -384,7 +384,7 @@ def create_command(meth) #:nodoc:
       @usage ||= nil
       @desc ||= nil
       @long_desc ||= nil
-      
+
       if @usage && @desc
         base_class = @hide ? Thor::HiddenCommand : Thor::Command
         commands[meth] = base_class.new(meth, @desc, @long_desc, @usage, method_options)

lib/thor/base.rb

@@ -439,7 +439,7 @@ def start(given_args = ARGV, config = {})
         config[:shell] ||= Thor::Base.shell.new
         dispatch(nil, given_args.dup, nil, config)
       rescue Thor::Error => e
-        ENV['THOR_DEBUG'] == '1' ? (raise e) : config[:shell].error(e.message)
+        config[:debug] || ENV['THOR_DEBUG'] == '1' ? (raise e) : config[:shell].error(e.message)
         exit(1) if exit_on_failure?
       rescue Errno::EPIPE
         # This happens if a thor command is piped to something like `head`,

lib/thor/line_editor/readline.rb

@@ -50,7 +50,7 @@ def use_path_completion?
       class PathCompletion
         attr_reader :text
         private :text
-        
+
         def initialize(text)
           @text = text
         end

spec/base_spec.rb

@@ -246,15 +246,22 @@ def hello
   describe '#start' do
     it 'raises an error instead of rescuing if THOR_DEBUG=1 is given' do
       begin
-        ENV['THOR_DEBUG'] = 1
+        ENV['THOR_DEBUG'] = '1'
+
         expect do
           MyScript.start %w[what --debug]
-        end.to raise_error(Thor::UndefinedcommandError, 'Could not find command "what" in "my_script" namespace.')
-      rescue
+        end.to raise_error(Thor::UndefinedCommandError, 'Could not find command "what" in "my_script" namespace.')
+      ensure
         ENV['THOR_DEBUG'] = nil
       end
     end
 
+    it 'raises an error instead of rescuing if :debug option is given' do
+      expect do
+        MyScript.start %w[what], :debug => true
+      end.to raise_error(Thor::UndefinedCommandError, 'Could not find command "what" in "my_script" namespace.')
+    end
+
     it 'does not steal args' do
       args = %w[foo bar --force true]
       MyScript.start(args)