Skip to content

Commit a870ce4

Browse files
Apply suggestions from self code review of v5.5.5-rc3
* Minor tweaks to various comments for correctness and readability Co-authored-by: Mr. Walls <reactive-firewall@users.noreply.github.com>
1 parent 187bca9 commit a870ce4

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
* Aligned parsing logic with [PEP 753](https://peps.python.org/pep-0753/)
1919
* Refactored to better leverage f-strings to improve performance slightly
20+
* Fixed various warnings in tests
21+
* Got rid of historical Python 3.5 left-overs
2022

2123
### 5.5.2
2224

Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ ifndef PIP_COMMON_FLAGS
8585
endif
8686

8787
ifeq "$(DEV_PAT)" ""
88+
# Replaces 'filelock==*' with 'filelock>=3.19.1' for Python 3.9 support
8889
DEV_PAT=s/^\(filelock\)\(=+\)\(\[0-9.\]+\)\$$/\\1\>\=3.19.1/g
8990
endif
9091

@@ -104,8 +105,12 @@ ifeq "$(DO_FAIL)" ""
104105
DO_FAIL=$(ECHO) "ok"
105106
endif
106107

107-
ifeq "$(MV)" ""
108-
MV=$(COMMAND) mv -f
108+
ifeq "$(SED)" ""
109+
SED=$(COMMAND) sed -r
110+
endif
111+
112+
ifeq "$(TEST)" ""
113+
TEST=builtin test
109114
endif
110115

111116
ifeq "$(RM)" ""

piplicenses.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494

9595

9696
def extract_homepage(metadata: Message) -> str | None:
97-
"""Extracts the home page from the package metadata.
97+
"""Extracts a homepage attribute from the package metadata.
9898
9999
Retrieve home page from the PEP 753 `Project-URL` metadata.
100100
As a fallback, try the Core Metadata 1.0 home-page attribute.
@@ -131,6 +131,7 @@ def extract_homepage(metadata: Message) -> str | None:
131131
"source",
132132
"repository",
133133
"changelog",
134+
"documentation",
134135
"bug tracker",
135136
):
136137
if priority_key in candidates:

0 commit comments

Comments
 (0)