add missing decrefs, implement rmdir()

Author: vortec

commands.c

@@ -12,6 +12,7 @@ int python_connect(vfs_handle_struct *handle,
         PyObject *py_ret = PyObject_CallFunction(py_func, "ss", service, user);
         success = PyObject_IsTrue(py_ret);
         Py_DECREF(py_ret);
+        Py_DECREF(py_func);
     }
 
     if (success == 1)
@@ -42,6 +43,7 @@ int python_mkdir(vfs_handle_struct *handle,
         PyObject *py_ret = PyObject_CallFunction(py_func, "s", path);
         success = PyObject_IsTrue(py_ret);
         Py_DECREF(py_ret);
+        Py_DECREF(py_func);
     }
 
     if (success == 1)
@@ -54,6 +56,29 @@ int python_mkdir(vfs_handle_struct *handle,
     }
 }
 
+int python_rmdir(vfs_handle_struct *handle, const char *path)
+{
+    int success = 1;
+
+    PyObject *py_func = get_func(handle, "rmdir");
+    if (py_func != NULL)
+    {
+        PyObject *py_ret = PyObject_CallFunction(py_func, "s", path);
+        success = PyObject_IsTrue(py_ret);
+        Py_DECREF(py_ret);
+        Py_DECREF(py_func);
+    }
+
+    if (success == 1)
+    {
+        return SMB_VFS_NEXT_RMDIR(handle, path);
+    }
+    else
+    {
+        return -1;
+    }
+}
+
 NTSTATUS python_create_file(struct vfs_handle_struct *handle,
                             struct smb_request *req,
                             uint16_t root_dir_fid,
@@ -79,6 +104,7 @@ NTSTATUS python_create_file(struct vfs_handle_struct *handle,
         PyObject *py_ret = PyObject_CallFunction(py_func, "s", smb_fname->base_name);
         success = PyObject_IsTrue(py_ret);
         Py_DECREF(py_ret);
+        Py_DECREF(py_func);
     }
 
     if (success == 1)
@@ -121,6 +147,7 @@ int python_rename(vfs_handle_struct *handle,
                                                  smb_fname_dst->base_name);
         success = PyObject_IsTrue(py_ret);
         Py_DECREF(py_ret);
+        Py_DECREF(py_func);
     }
 
     if (success == 1)

commands.h

@@ -8,6 +8,7 @@ void python_disconnect(vfs_handle_struct *handle);
 int python_mkdir(vfs_handle_struct *handle,
                  const char *path,
                  mode_t mode);
+int python_rmdir(vfs_handle_struct *handle, const char *path);
 
 NTSTATUS python_create_file(struct vfs_handle_struct *handle,
                             struct smb_request *req,

handler.py

@@ -10,6 +10,12 @@ def mkdir(path):
     debug('Create dir: {}'.format(path))
     return True
 
+def rmdir(path):
+    debug('Remove dir: {}'.format(path))
+    if path == 'dont_touch_this':
+        return False
+    return True
+
 def create_file(path):
     debug('Create file: {}'.format(path))
     if path == 'bad_file':

vfs_python.c

@@ -5,6 +5,7 @@ static struct vfs_fn_pointers vfs_python_fns = {
         .connect_fn = python_connect,
         .disconnect_fn = python_disconnect,
         .mkdir_fn = python_mkdir,
+        .rmdir_fn = python_rmdir,
         .create_file_fn = python_create_file,
         .rename_fn = python_rename
 };