Skip to content

Commit 9012551

Browse files
committed
platform: Generalize log message indicating network flush behavior
Signed-off-by: Raghu Raja <raghunch@amazon.com>
1 parent 8f37377 commit 9012551

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

src/platform-aws.cpp

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -498,16 +498,19 @@ int platform_init(const char **provider_filter)
498498
if ((platform_data && !platform_data->net_flush_required) &&
499499
NULL == getenv("NCCL_NET_FORCE_FLUSH")) {
500500

501-
/* Hopper GPUs do not require a network flush, but NCCL versions <2.19.1
502-
* still enable flush by default on any GPU type.
503-
* For GPU generations earlier than Hopper, NCCL always enables flush, while
504-
* for Hopper GPUs flush is enabled or disabled depending on the value of
505-
* the NCCL_NET_FORCE_FLUSH environment variable. The default value for this
506-
* variable is 1 for NCCL versions <2.19.1, which forces flush when it is not
507-
* needed, so it is safe to set it to 0 if it is not explicitly set.
508-
*/
509-
510-
NCCL_OFI_INFO(NCCL_INIT | NCCL_NET, "Setting NCCL_NET_FORCE_FLUSH=0 for Hopper GPUs");
501+
/*
502+
* Certain GPU architectures do not require a network flush, but
503+
* NCCL versions <2.19.1 still enable flush by default on any
504+
* GPU type. For GPU generations earlier than Hopper, NCCL
505+
* always enables flush, while for Hopper GPUs flush is enabled
506+
* or disabled depending on the value of the
507+
* NCCL_NET_FORCE_FLUSH environment variable. The default value
508+
* for this variable is 1 for NCCL versions <2.19.1, which
509+
* forces flush when it is not needed, so it is safe to set it
510+
* to 0 if it is not explicitly set.
511+
*/
512+
513+
NCCL_OFI_INFO(NCCL_INIT | NCCL_NET, "Setting NCCL_NET_FORCE_FLUSH=0 since this platform does not require a network flush.");
511514
ret = setenv("NCCL_NET_FORCE_FLUSH", "0", 0);
512515
if (ret != 0) {
513516
NCCL_OFI_WARN("Unable to set NCCL_NET_FORCE_FLUSH");

0 commit comments

Comments
 (0)