Skip to content

Commit d4b3edf

Browse files
authored
Merge pull request #15 from jarojasm95/issue-14-KUBE_EDITOR
Default to KUBE_EDITOR and keep EDITOR as fallback
2 parents eceaa75 + 218cede commit d4b3edf

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

pkg/editor/editor.go

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,22 @@ import (
88

99
const defaultEditor = "vi"
1010

11+
func getEditor() string {
12+
if os.Getenv("KUBE_EDITOR") != "" {
13+
return os.Getenv("KUBE_EDITOR")
14+
}
15+
16+
if os.Getenv("EDITOR") != "" {
17+
return os.Getenv("EDITOR")
18+
}
19+
20+
return defaultEditor
21+
}
22+
1123
//Edit opens the editor
1224
func Edit(file string) error {
13-
editorFromEnv := os.Getenv("EDITOR")
14-
if editorFromEnv == "" {
15-
editorFromEnv = defaultEditor
16-
}
1725

18-
command, args := getCommandAndArgs(editorFromEnv, file)
26+
command, args := getCommandAndArgs(getEditor(), file)
1927

2028
cmd := exec.Command(command, args...)
2129
cmd.Stdin = os.Stdin

0 commit comments

Comments
 (0)