Fixed bug in PDB age

Author: rajkumar-rangaraj

SymbolFetch/App.config

@@ -1,8 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <configuration>
-  <!--<appSettings>
-    <add key="SymbolServer" value="http://symweb"/>
-  </appSettings>-->
     <startup> 
         <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />
     </startup>

SymbolFetch/FileDownloader.cs

@@ -264,6 +264,7 @@ private void bgwDownloader_DoWork(object sender, DoWorkEventArgs e)
         private void calculateFilesSize()
         {
             fireEventFromBgw(Event.CalculationFileSizesStarted);
+            bool headVerb = true;
             m_totalSize = 0;
             string message;
             for (Int32 fileNr = 0; fileNr < this.Files.Count; fileNr++)
@@ -274,12 +275,13 @@ private void calculateFilesSize()
                     //Probe 1
                     HttpWebRequest webReq = (HttpWebRequest)WebRequest.Create(this.Files[fileNr].Path);
                     webReq.UserAgent = Constants.SymbolServer;
+                    webReq.Method = "HEAD";
                     HttpWebResponse webResp = (HttpWebResponse)webReq.GetResponseNoException();
 
                     //Probe 2
                     if (webResp.StatusCode == HttpStatusCode.NotFound)
                     {
-                        webResp = Retry(fileNr);
+                        webResp = Retry(fileNr, headVerb);
                     }
 
                     if (webResp.StatusCode == HttpStatusCode.OK)
@@ -310,12 +312,14 @@ private void calculateFilesSize()
             fireEventFromBgw(Event.FileSizesCalculationComplete);
         }
 
-        private HttpWebResponse Retry(int fileNr)
+        private HttpWebResponse Retry(int fileNr, bool headVerb)
         {
             string path = this.Files[fileNr].Path;
             path = ProbeWithUnderscore(path);
             var webReq = (HttpWebRequest)System.Net.WebRequest.Create(path);
             webReq.UserAgent = Constants.SymbolServer;
+            if(headVerb)
+                webReq.Method = "HEAD";
             return (HttpWebResponse)webReq.GetResponseNoException();
         }
 
@@ -344,11 +348,18 @@ private long ProcessFileSize(HttpWebResponse webResp, out string filePath)
             {
                 file = file.Substring(5, file.Length - 5); //Removing PATH: from the output
 
-                System.IO.FileInfo fInfo = new System.IO.FileInfo(file);
-                if (fInfo.Exists)
+                try
+                {
+                    System.IO.FileInfo fInfo = new System.IO.FileInfo(file);
+                    if (fInfo.Exists)   
+                    {
+                        length = fInfo.Length;
+                        filePath = file;
+                    }
+                }
+                catch(Exception ex)
                 {
-                    length = fInfo.Length;
-                    filePath = file;
+                    WriteToLog(file, ex);
                 }
             }
             else
@@ -389,6 +400,7 @@ private void fireEventFromBgw(Event eventName)
 
         private void downloadFile(Int32 fileNr)
         {
+            bool headVerb = false;
             m_currentFileSize = 0;
             bool fileptr = false;
             fireEventFromBgw(Event.FileDownloadAttempting);
@@ -417,7 +429,7 @@ private void downloadFile(Int32 fileNr)
                 webResp = (HttpWebResponse)webReq.GetResponseNoException();
                 if (webResp.StatusCode == HttpStatusCode.NotFound)
                 {
-                    webResp = Retry(fileNr);
+                    webResp = Retry(fileNr, headVerb);
 
                     if (webResp.StatusCode == HttpStatusCode.OK)
                     {
@@ -433,7 +445,8 @@ private void downloadFile(Int32 fileNr)
 
                     if (webResp.StatusCode != HttpStatusCode.OK)
                     {
-                        FailedFiles.Add(file.Name, " - " + webResp.StatusCode + "  " + webResp.StatusDescription);
+                        if (!FailedFiles.ContainsKey(file.Name))
+                            FailedFiles.Add(file.Name, " - " + webResp.StatusCode + "  " + webResp.StatusDescription);
                     }
                 }
                 else if(webResp.StatusCode == HttpStatusCode.OK)
@@ -559,7 +572,7 @@ public static void WriteToLog(string fileName, Exception exc)
             using (FileStream fs = new FileStream("Log.txt", FileMode.Append))
             using (StreamWriter sr = new StreamWriter(fs))
             {
-                sr.WriteLine(DateTime.Now.ToString() + "   " + fileName + ": " + exc.Message);
+                sr.WriteLine(DateTime.Now.ToString() + "   " + fileName + " - " + exc.Message);
             }
         }
 
@@ -568,7 +581,7 @@ public static void WriteToLog(string fileName, string text)
             using (FileStream fs = new FileStream("Log.txt", FileMode.Append))
             using (StreamWriter sr = new StreamWriter(fs))
             {
-                sr.WriteLine(DateTime.Now.ToString() + "   " + fileName + ": " + text);
+                sr.WriteLine(DateTime.Now.ToString() + "   " + fileName + " - " + text);
             }
         }
 

SymbolFetch/MainWindow.xaml.cs

@@ -5,6 +5,8 @@
 using System.IO;
 using System.Windows;
 using System.Windows.Input;
+using System.Linq;
+
 
 namespace SymbolFetch
 {
@@ -170,6 +172,9 @@ private void btnBulk_Click(object sender, RoutedEventArgs e)
                 {
                     fileList.Add(line);
                 }
+
+                fileList = fileList.Distinct().ToList();
+
                 if (fileList.Count > 0)
                 {
                     lstFiles.Visibility = Visibility.Visible;

SymbolFetch/PeHeaderReader.cs

@@ -288,7 +288,7 @@ public struct IMAGE_DEBUG_DIRECTORY_RAW
         private IMAGE_DEBUG_DIRECTORY_RAW DebugInfo;
 
         private string _pdbName = "";
-        private int _pdbage = 0;
+        private string _pdbage = "";
         private Guid _debugGUID;
 
         #endregion Private Fields
@@ -402,7 +402,7 @@ public PeHeaderReader(string filePath)
                     _pdbName = new string(DebugInfo.name);
                     _pdbName = _pdbName.Remove(_pdbName.IndexOf("\0"));
 
-                    _pdbage = (int)DebugInfo.age;
+                    _pdbage = DebugInfo.age.ToString("X");
                     _debugGUID = DebugInfo.guid;
                 }
 
@@ -425,7 +425,7 @@ public static T FromBinaryReader<T>(BinaryReader reader)
         #region Properties
 
         public string pdbName { get { return _pdbName; } }
-        public int pdbage { get { return _pdbage; } }
+        public string pdbage { get { return _pdbage; } }
         public Guid debugGUID { get { return _debugGUID; } }
 
         public bool Is32BitHeader

SymbolFetch/UrlBuilder.cs

@@ -40,9 +40,9 @@ public string BuildUrl(string filename)
                     SymbolServerUrl = ConfigurationReader.SymbolServerUrl;
 
                     if (string.IsNullOrEmpty(SymbolServerUrl))
-                        downloadURL = "http://msdl.microsoft.com/download/symbols/" + pdbName + "/" + reader.debugGUID.ToString("N").ToUpper() + reader.pdbage.ToString() + "/" + pdbName;
+                        downloadURL = "http://msdl.microsoft.com/download/symbols/" + pdbName + "/" + reader.debugGUID.ToString("N").ToUpper() + reader.pdbage + "/" + pdbName;
                     else
-                        downloadURL = SymbolServerUrl + "/" + pdbName + "/" + reader.debugGUID.ToString("N").ToUpper() + reader.pdbage.ToString() + "/" + pdbName;
+                        downloadURL = SymbolServerUrl + "/" + pdbName + "/" + reader.debugGUID.ToString("N").ToUpper() + reader.pdbage + "/" + pdbName;
                 }
             }
             return downloadURL;