[Out-of-process-collection] Add tests for Tracing Implementation (open-telemetry#4345)

* New trace tests.

* Remove static constructor from proto tests, Fix test interfence with metrics by introducing Allowed MeterNames, Fix other tracing test failures.

* remove assert true.

Author: rajkumar-rangaraj

next-gen/test/OpenTelemetry.AutoInstrumentation.Sdk.Tests/OtlpMeasurementCollector.cs

@@ -17,6 +17,7 @@ internal sealed class OtlpMeasurementCollector : IDisposable
 {
     private readonly MeterListener _MeterListener;
     private readonly Resource _Resource;
+    private readonly HashSet<string> _AllowedMeterNames = new();
     private readonly List<CollectedMeasurement> _Measurements = new();
     private readonly object _Lock = new();
     private TaskCompletionSource<CollectedMeasurement>? _SingleMeasurementTcs;
@@ -29,7 +30,11 @@ public OtlpMeasurementCollector(Resource resource)
         _MeterListener = new MeterListener();
         _MeterListener.InstrumentPublished = (instrument, listener) =>
         {
-            listener.EnableMeasurementEvents(instrument);
+            // Only enable measurements for explicitly allowed meters to avoid capturing runtime metrics
+            if (_AllowedMeterNames.Contains(instrument.Meter.Name))
+            {
+                listener.EnableMeasurementEvents(instrument);
+            }
         };
 
         // Register callbacks for different measurement types
@@ -41,6 +46,14 @@ public OtlpMeasurementCollector(Resource resource)
         _MeterListener.Start();
     }
 
+    public void AllowMeter(string meterName)
+    {
+        lock (_Lock)
+        {
+            _AllowedMeterNames.Add(meterName);
+        }
+    }
+
     public void Dispose()
     {
         _MeterListener?.Dispose();
@@ -146,7 +159,7 @@ internal async Task<CollectedMeasurement> WaitForMeasurementAsync(TimeSpan timeo
         {
             if (_Measurements.Count > 0)
             {
-                return _Measurements.Last();
+                return _Measurements[_Measurements.Count - 1];
             }
 
             _SingleMeasurementTcs = new TaskCompletionSource<CollectedMeasurement>();

next-gen/test/OpenTelemetry.AutoInstrumentation.Sdk.Tests/ProtobufOtlpMetricExporterAsyncTests.cs

@@ -28,6 +28,7 @@ public async Task ToOtlpResourceMetricsTest()
 
         // Create the measurement collector
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("ToOtlpResourceMetricsTest");
 
         // Create meter and counter
         using var meter = new Meter(name: "ToOtlpResourceMetricsTest", version: "0.0.1", tags: meterTags);
@@ -74,6 +75,7 @@ public async Task ToOtlpResourceMetricsWithMultipleCountersTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("MultiCounterTest");
 
         using var meter = new Meter(name: "MultiCounterTest", version: "1.0.0");
         var counter1 = meter.CreateCounter<int>("requests");
@@ -107,6 +109,7 @@ public async Task ToOtlpResourceMetricsWithDifferentTypesTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("MixedTypesTest");
 
         using var meter = new Meter(name: "MixedTypesTest", version: "1.0.0");
         var intCounter = meter.CreateCounter<int>("int_counter");
@@ -146,6 +149,7 @@ public async Task ToOtlpResourceMetricsWithUpDownCounterTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("UpDownCounterTest");
 
         using var meter = new Meter(name: "UpDownCounterTest", version: "1.0.0");
         var upDownCounter = meter.CreateUpDownCounter<int>("requests_active");
@@ -180,6 +184,7 @@ public async Task ToOtlpResourceMetricsWithHistogramTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("HistogramTest");
 
         using var meter = new Meter(name: "HistogramTest", version: "1.0.0");
         var histogram = meter.CreateHistogram<double>("request_duration");
@@ -224,6 +229,7 @@ public async Task ToOtlpResourceMetricsWithLongUpDownCounterTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("LongUpDownCounterTest");
 
         using var meter = new Meter(name: "LongUpDownCounterTest", version: "1.0.0");
         var upDownCounter = meter.CreateUpDownCounter<long>("memory_usage_bytes");
@@ -255,6 +261,7 @@ public async Task ToOtlpResourceMetricsWithIntHistogramTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("IntHistogramTest");
 
         using var meter = new Meter(name: "IntHistogramTest", version: "1.0.0");
         var histogram = meter.CreateHistogram<int>("response_size_bytes");
@@ -303,6 +310,7 @@ public async Task ToOtlpResourceMetricsWithFloatGaugeTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("FloatGaugeTest");
 
         using var meter = new Meter(name: "FloatGaugeTest", version: "1.0.0");
         var gauge = meter.CreateGauge<float>("cpu_usage_percent");
@@ -350,6 +358,7 @@ public async Task ToOtlpResourceMetricsWithMixedInstrumentTypesTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("MixedInstrumentsTest");
 
         using var meter = new Meter(name: "MixedInstrumentsTest", version: "1.0.0");
 
@@ -406,6 +415,7 @@ public async Task ToOtlpResourceMetricsWithTagsAndAttributesTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("TagsTest");
 
         using var meter = new Meter(name: "TagsTest", version: "1.0.0");
         var counter = meter.CreateCounter<int>("http_requests");
@@ -454,6 +464,7 @@ public async Task ToOtlpResourceMetricsWithComplexTagsTest()
         });
 
         using var collector = new OtlpMeasurementCollector(resource);
+        collector.AllowMeter("ComplexTagsTest");
 
         using var meter = new Meter(name: "ComplexTagsTest", version: "1.0.0");
         var histogram = meter.CreateHistogram<double>("database_query_duration");

next-gen/test/OpenTelemetry.AutoInstrumentation.Sdk.Tests/ProtobufOtlpSpanExporterAsyncTests.cs

@@ -12,16 +12,20 @@ namespace OpenTelemetry.AutoInstrumentation.Sdk.Tests;
 
 public sealed class ProtobufOtlpSpanExporterAsyncTests : IDisposable
 {
-    static ProtobufOtlpSpanExporterAsyncTests()
-    {
-        Activity.DefaultIdFormat = ActivityIdFormat.W3C;
-        Activity.ForceDefaultIdFormat = true;
-    }
-
     private readonly ActivityListener _ActivityListener;
+    private readonly ActivityIdFormat _PreviousDefaultIdFormat;
+    private readonly bool _PreviousForceDefaultIdFormat;
 
     public ProtobufOtlpSpanExporterAsyncTests()
     {
+        // Store previous global settings
+        _PreviousDefaultIdFormat = Activity.DefaultIdFormat;
+        _PreviousForceDefaultIdFormat = Activity.ForceDefaultIdFormat;
+
+        // Set test-specific global settings
+        Activity.DefaultIdFormat = ActivityIdFormat.W3C;
+        Activity.ForceDefaultIdFormat = true;
+
         _ActivityListener = new ActivityListener
         {
             ShouldListenTo = _ => true,
@@ -36,6 +40,10 @@ public ProtobufOtlpSpanExporterAsyncTests()
     public void Dispose()
     {
         _ActivityListener.Dispose();
+
+        // Restore previous global settings
+        Activity.DefaultIdFormat = _PreviousDefaultIdFormat;
+        Activity.ForceDefaultIdFormat = _PreviousForceDefaultIdFormat;
     }
 
     [Fact]

next-gen/test/OpenTelemetry.AutoInstrumentation.Sdk.Tests/Serializer/OtlpArrayTagWriterTests.cs

@@ -8,17 +8,21 @@ namespace OpenTelemetry.AutoInstrumentation.Sdk.Tests.Serializer;
 
 public sealed class OtlpArrayTagWriterTests : IDisposable
 {
-    static OtlpArrayTagWriterTests()
-    {
-        Activity.DefaultIdFormat = ActivityIdFormat.W3C;
-        Activity.ForceDefaultIdFormat = true;
-    }
-
     private readonly ProtobufOtlpTagWriter.OtlpArrayTagWriter _ArrayTagWriter;
     private readonly ActivityListener _ActivityListener;
+    private readonly ActivityIdFormat _PreviousDefaultIdFormat;
+    private readonly bool _PreviousForceDefaultIdFormat;
 
     public OtlpArrayTagWriterTests()
     {
+        // Store previous global settings
+        _PreviousDefaultIdFormat = Activity.DefaultIdFormat;
+        _PreviousForceDefaultIdFormat = Activity.ForceDefaultIdFormat;
+
+        // Set test-specific global settings
+        Activity.DefaultIdFormat = ActivityIdFormat.W3C;
+        Activity.ForceDefaultIdFormat = true;
+
         _ArrayTagWriter = new ProtobufOtlpTagWriter.OtlpArrayTagWriter();
         _ActivityListener = new ActivityListener
         {
@@ -150,5 +154,9 @@ public void Dispose()
         // Clean up the thread buffer after each test
         ProtobufOtlpTagWriter.OtlpArrayTagWriter.s_ThreadBuffer = null;
         _ActivityListener.Dispose();
+
+        // Restore previous global settings
+        Activity.DefaultIdFormat = _PreviousDefaultIdFormat;
+        Activity.ForceDefaultIdFormat = _PreviousForceDefaultIdFormat;
     }
 }