Fix inconsistent error message for getting a non-existent item #74

Author: joelvdavies

inventory_management_system_api/routers/v1/item.py

@@ -5,7 +5,7 @@
 import logging
 from typing import Annotated, List, Optional
 
-from fastapi import APIRouter, Depends, HTTPException, Path, Request, Query, status
+from fastapi import APIRouter, Depends, HTTPException, Path, Query, Request, status
 
 from inventory_management_system_api.core.config import config
 from inventory_management_system_api.core.exceptions import (
@@ -15,8 +15,8 @@
     InvalidPropertyTypeError,
     MissingMandatoryProperty,
     MissingRecordError,
-    ObjectStorageAPIServerError,
     ObjectStorageAPIAuthError,
+    ObjectStorageAPIServerError,
 )
 from inventory_management_system_api.schemas.item import ItemPatchSchema, ItemPostSchema, ItemSchema
 from inventory_management_system_api.services.item import ItemService
@@ -126,7 +126,7 @@ def get_item(
 ) -> ItemSchema:
     # pylint: disable=missing-function-docstring
     logger.info("Getting item with ID %s", item_id)
-    message = "An item with such ID was not found"
+    message = "Item not found"
     try:
         item = item_service.get(item_id)
         if not item:

test/e2e/test_item.py

@@ -630,13 +630,13 @@ def test_get_with_non_existent_id(self):
         """Test getting an item with a non-existent ID."""
 
         self.get_item(str(ObjectId()))
-        self.check_get_item_failed_with_detail(404, "An item with such ID was not found")
+        self.check_get_item_failed_with_detail(404, "Item not found")
 
     def test_get_with_invalid_id(self):
         """Test getting an item with an invalid ID."""
 
         self.get_item("invalid-id")
-        self.check_get_item_failed_with_detail(404, "An item with such ID was not found")
+        self.check_get_item_failed_with_detail(404, "Item not found")
 
 
 class ListDSL(GetDSL):
@@ -1176,7 +1176,7 @@ def test_delete(self):
         self.check_delete_item_success()
 
         self.get_item(item_id)
-        self.check_get_item_failed_with_detail(404, "An item with such ID was not found")
+        self.check_get_item_failed_with_detail(404, "Item not found")
 
     def test_delete_with_non_existent_id(self):
         """Test deleting a non-existent item."""