Merge pull request #629 from ral-facilities/fix-runtime-error-when-no-spares-#628

Replace JSONResponse with Response to fix runtime error #628

Author: joelvdavies

inventory_management_system_api/routers/v1/setting.py

@@ -11,7 +11,7 @@
 from typing import Annotated
 
 from fastapi import APIRouter, Depends, status
-from fastapi.responses import JSONResponse
+from fastapi.responses import Response
 
 from inventory_management_system_api.schemas.setting import SparesDefinitionSchema
 from inventory_management_system_api.services.setting import SettingService
@@ -37,6 +37,6 @@ def get_spares_definition(setting_service: SettingServiceDep):
     setting = setting_service.get_spares_definition()
 
     if setting is None:
-        return JSONResponse(status_code=status.HTTP_204_NO_CONTENT, content=None)
+        return Response(status_code=status.HTTP_204_NO_CONTENT, content=None)
 
     return SparesDefinitionSchema(**setting.model_dump())

test/unit/repositories/test_item.py

@@ -647,7 +647,7 @@ def check_count_in_catalogue_item_with_system_type_one_of(self) -> None:
             ],
             session=self.mock_session,
         )
-        assert self._expected_count == self._obtained_count
+        assert self._obtained_count == self._expected_count
 
 
 class TestCountInCatalogueItemWithSystemTypeOneOf(CountInCatalogueItemWithSystemTypeOneOfDSL):