Merge branch 'add-ims-job-scheduler-api-url-to-config-#1676' into catalogue-catagories-flagging-#1659

Author: joshdimanteto

cypress/support/commands.ts

@@ -162,7 +162,7 @@ Cypress.Commands.add('setMode', ({ admin = false, critical = false } = {}) => {
 
   // Toggle critical mode
   if (critical) {
-    cy.findByRole('menuitem', { name: 'Switch to critical mode on' }).click();
+    cy.findByRole('menuitem', { name: 'Switch critical mode on' }).click();
   }
 });
 

src/common/storage.test.ts

@@ -1,7 +1,7 @@
 import { createBooleanLocalStorage } from './storage';
 
-describe('isAdminModeStorage', () => {
-  const isAdminModeStorage = createBooleanLocalStorage('test');
+describe('createBooleanLocalStorage', () => {
+  const testBooleanStorage = createBooleanLocalStorage('test');
   const localStorageGetItemMock = vi.spyOn(
     window.localStorage.__proto__,
     'getItem'
@@ -28,7 +28,7 @@ describe('isAdminModeStorage', () => {
     it('should return true when stored value is "true"', () => {
       localStorageGetItemMock.mockImplementationOnce(() => 'true');
 
-      const result = isAdminModeStorage.load();
+      const result = testBooleanStorage.load();
 
       expect(result).toBe(true);
       expect(localStorageGetItemMock).toHaveBeenCalledWith(KEY);
@@ -37,45 +37,45 @@ describe('isAdminModeStorage', () => {
     it('should return false when stored value is "false"', () => {
       localStorageGetItemMock.mockImplementationOnce(() => 'false');
 
-      const result = isAdminModeStorage.load();
+      const result = testBooleanStorage.load();
 
       expect(result).toBe(false);
     });
 
     it('should return undefined when value is missing', () => {
       localStorageGetItemMock.mockImplementationOnce(() => null);
 
-      const result = isAdminModeStorage.load();
+      const result = testBooleanStorage.load();
 
       expect(result).toBeUndefined();
     });
 
     it('should return undefined for an invalid value', () => {
       localStorageGetItemMock.mockImplementationOnce(() => 'garbage');
 
-      const result = isAdminModeStorage.load();
+      const result = testBooleanStorage.load();
 
       expect(result).toBeUndefined();
     });
   });
 
   describe('save', () => {
     it('should store "true"', () => {
-      isAdminModeStorage.save(true);
+      testBooleanStorage.save(true);
 
       expect(localStorageSetItemMock).toHaveBeenCalledWith(KEY, 'true');
     });
 
     it('should store "false"', () => {
-      isAdminModeStorage.save(false);
+      testBooleanStorage.save(false);
 
       expect(localStorageSetItemMock).toHaveBeenCalledWith(KEY, 'false');
     });
   });
 
   describe('clear', () => {
     it('should remove the key from localStorage', () => {
-      isAdminModeStorage.clear();
+      testBooleanStorage.clear();
 
       expect(localStorageRemoveItemMock).toHaveBeenCalledWith(KEY);
     });