Skip to content

Commit 8ef88e9

Browse files
Merge pull request #1677 from ral-facilities/add-ims-job-scheduler-api-url-to-config-#1676
add the ims-job-scheduler-api url to config #1676
2 parents ba16ae6 + 54aefec commit 8ef88e9

File tree

10 files changed

+19
-1
lines changed

10 files changed

+19
-1
lines changed

Dockerfile.prod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ USER www-data
6868

6969
ENV IMS_API_URL="/inventory-management-system-api"
7070
ENV OS_API_URL="/object-storage-api"
71+
ENV IMS_JS_API_URL="/ims-job-scheduler-api"
7172
ENV PLUGIN_HOST="/inventory-management-system"
7273
ENV MAX_ATTACHMENT_SIZE_BYTES=104857600
7374
ENV ATTACHMENT_ALLOWED_FILE_EXTENSIONS='[".csv", ".doc", ".docx", ".pdf", ".rtf", ".txt", ".xls", ".xlsx"]'

docker/docker-entrypoint.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ TEMPFILE="$(mktemp)"
77
jq \
88
--arg imsApiUrl "$IMS_API_URL" \
99
--arg osApiUrl "$OS_API_URL" \
10+
--arg imsJsApiUrl "$IMS_JS_API_URL" \
1011
--argjson maxAttachmentSizeBytes $MAX_ATTACHMENT_SIZE_BYTES \
1112
--argjson attachmentAllowedFileExtensions "$ATTACHMENT_ALLOWED_FILE_EXTENSIONS" \
1213
--argjson imageAllowedFileExtensions "$IMAGE_ALLOWED_FILE_EXTENSIONS" \

public/inventory-management-system-settings.example.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"imsApiUrl": "",
33
"osApiUrl": "",
4+
"imsJsApiUrl": "",
45
"maxAttachmentSizeBytes": 104857600,
56
"attachmentAllowedFileExtensions": [
67
".csv",

server/e2e-settings-with-api.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"imsApiUrl": "http://127.0.0.1:8000",
33
"osApiUrl": "http://127.0.0.1:8002",
4+
"imsJsApiUrl": "",
45
"maxAttachmentSizeBytes": 104857600,
56
"attachmentAllowedFileExtensions": [
67
".csv",

server/e2e-settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"imsApiUrl": "",
33
"osApiUrl": "",
4+
"imsJsApiUrl": "",
45
"maxAttachmentSizeBytes": 104857600,
56
"attachmentAllowedFileExtensions": [
67
".csv",

src/api/api.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,3 +145,7 @@ export const imsApi = createAuthenticatedClient({
145145
export const storageApi = createAuthenticatedClient({
146146
getURL: (settings) => settings.osApiUrl,
147147
});
148+
149+
export const jobSchedulerApi = createAuthenticatedClient({
150+
getURL: (settings) => settings.imsJsApiUrl,
151+
});

src/main.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ export const fetchSettings =
127127
throw new Error('osApiUrl is undefined in settings');
128128
}
129129

130+
// Ensure the imsJsApiUrl name exists.
131+
if (!('imsJsApiUrl' in settings)) {
132+
throw new Error('imsJsApiUrl is undefined in settings');
133+
}
134+
130135
// Ensure the maxAttachmentSizeBytes value exists.
131136
if (!('maxAttachmentSizeBytes' in settings)) {
132137
throw new Error('maxAttachmentSizeBytes is undefined in settings');
@@ -210,7 +215,8 @@ async function prepare() {
210215
if (
211216
import.meta.env.VITE_INCLUDE_MSW === 'true' ||
212217
settingsResult?.imsApiUrl === '' ||
213-
settingsResult?.osApiUrl === ''
218+
settingsResult?.osApiUrl === '' ||
219+
settingsResult?.imsJsApiUrl === ''
214220
) {
215221
// Need to use require instead of import as import breaks when loaded in SG
216222
const { worker } = await import('./mocks/browser');

src/settings.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { PluginRoute } from './state/actions/actions.types';
33
export interface InventoryManagementSystemSettings {
44
imsApiUrl: string;
55
osApiUrl: string;
6+
imsJsApiUrl: string;
67
maxAttachmentSizeBytes: number;
78
attachmentAllowedFileExtensions: string[];
89
imageAllowedFileExtensions: string[];

src/state/slices/configSlice.test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ describe('configSlice', () => {
66
const initialSettings: InventoryManagementSystemSettings = {
77
imsApiUrl: '',
88
osApiUrl: '',
9+
imsJsApiUrl: '',
910
maxAttachmentSizeBytes: 104857600,
1011
attachmentAllowedFileExtensions: [
1112
'.csv',

src/state/slices/configSlice.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export interface ConfigState {
1313
const initialSettings: InventoryManagementSystemSettings = {
1414
imsApiUrl: '',
1515
osApiUrl: '',
16+
imsJsApiUrl: '',
1617
maxAttachmentSizeBytes: 104857600,
1718
attachmentAllowedFileExtensions: [
1819
'.csv',

0 commit comments

Comments
 (0)