Fix crash in CPU BuddyAllocator ~Page when block_ldlt throws

kkofler · kkofler · commit 6299940485fb · 2025-04-02T14:55:28.000+02:00
src/ssids/cpu/BuddyAllocator.hxx
(spral::ssids::cpu::buddy_alloc_internal::Page::~Page): Remove invalid
sanity check. When an exception is thrown, this condition is not
satisfied.
diff --git a/src/ssids/cpu/BuddyAllocator.hxx b/src/ssids/cpu/BuddyAllocator.hxx
@@ -101,8 +101,6 @@ public:
 #endif /* MEM_STATS */
    }
    ~Page() noexcept(false) {
-      if(next_ && head_[nlevel-1] != 0)
-         throw std::runtime_error("outstanding allocations on cleanup\n");
       if(next_) {
          typename IntAllocTraits::allocator_type intAlloc(alloc_);
          IntAllocTraits::deallocate(intAlloc, next_, 1<<(nlevel-1));

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,6 @@ public:`
`101`	`101`	`#endif /* MEM_STATS */`
`102`	`102`	`}`
`103`	`103`	`~Page() noexcept(false) {`
`104`		`- if(next_ && head_[nlevel-1] != 0)`
`105`		`- throw std::runtime_error("outstanding allocations on cleanup\n");`
`106`	`104`	`if(next_) {`
`107`	`105`	`typename IntAllocTraits::allocator_type intAlloc(alloc_);`
`108`	`106`	`IntAllocTraits::deallocate(intAlloc, next_, 1<<(nlevel-1));`