refactor: removed unnecessary pointers to slices

Author: ralvarezdev

mongodb/collection.go

@@ -11,7 +11,7 @@ type (
 	// Collection represents a MongoDB collection
 	Collection struct {
 		name    string
-		Indexes *[]*mongo.IndexModel
+		Indexes []*mongo.IndexModel
 	}
 )
 
@@ -27,7 +27,7 @@ type (
 //   - *Collection: the new collection
 func NewCollection(
 	name string,
-	indexes *[]*mongo.IndexModel,
+	indexes []*mongo.IndexModel,
 ) *Collection {
 	return &Collection{
 		name,
@@ -64,20 +64,22 @@ func (c Collection) CreateCollection(database *mongo.Database) (
 //
 //   - error: if there was an error creating the indexes
 func (c Collection) createIndexes(collection *mongo.Collection) (err error) {
-	if c.Indexes != nil {
-		for _, index := range *c.Indexes {
-			// Check if the index is nil
-			if index == nil {
-				continue
-			}
+	if c.Indexes == nil {
+		return nil
+	}
+
+	for _, index := range c.Indexes {
+		// Check if the index is nil
+		if index == nil {
+			continue
+		}
 
-			// Create the index
-			_, err = collection.Indexes().CreateOne(
-				context.Background(), *index,
-			)
-			if err != nil {
-				return fmt.Errorf(ErrFailedToCreateIndex, *index, err)
-			}
+		// Create the index
+		_, err = collection.Indexes().CreateOne(
+			context.Background(), *index,
+		)
+		if err != nil {
+			return fmt.Errorf(ErrFailedToCreateIndex, *index, err)
 		}
 	}
 	return nil

sql/queries.go

@@ -15,11 +15,11 @@ import (
 //
 // Returns:
 //
-//	*[]error: A pointer to a slice of errors, or nil if no errors occurred
+//	[]error: A slice of errors, or nil if no errors occurred
 func RunQueriesConcurrently(
 	db *sql.DB,
 	queries ...func(db *sql.DB) error,
-) *[]error {
+) []error {
 	// Create a wait group
 	var wg sync.WaitGroup
 	wg.Add(len(queries))
@@ -55,7 +55,7 @@ func RunQueriesConcurrently(
 		return nil
 	}
 
-	return &errors
+	return errors
 }
 
 // RunQueriesConcurrentlyWithCancel runs multiple queries concurrently with a cancel context
@@ -67,11 +67,11 @@ func RunQueriesConcurrently(
 //
 // Returns:
 //
-//	*[]error: A pointer to a slice of errors, or nil if no errors occurred
+//	[]error: A slice of errors, or nil if no errors occurred
 func RunQueriesConcurrentlyWithCancel(
 	db *sql.DB,
 	queries ...func(db *sql.DB, ctx context.Context) error,
-) *[]error {
+) []error {
 	// Create a context with a cancellation function
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
@@ -114,5 +114,5 @@ func RunQueriesConcurrentlyWithCancel(
 		return nil
 	}
 
-	return &errors
+	return errors
 }