refactor: now, usernames can contain only alphanumeric characters

ralvarezdev · ralvarezdev · commit a2e4f0c0218b · 2025-03-07T12:45:56.000-04:00
diff --git a/go.mod b/go.mod
@@ -2,10 +2,10 @@ module github.com/ralvarezdev/go-validator
 
 go 1.23.4
 
-require github.com/ralvarezdev/go-flags v0.3.2 // indirect
+require github.com/ralvarezdev/go-flags v0.3.3 // indirect
 
 require (
 	github.com/ralvarezdev/go-logger v0.4.6
 	github.com/ralvarezdev/go-reflect v0.2.4
-	github.com/ralvarezdev/go-strings v0.1.9
+	github.com/ralvarezdev/go-strings v0.1.11
 )
diff --git a/go.sum b/go.sum
@@ -1,8 +1,10 @@
 github.com/ralvarezdev/go-flags v0.3.2 h1:l3f62CD5NysLAJH5XqSRGiakU/dn4pTGdX4yaBlAmMw=
 github.com/ralvarezdev/go-flags v0.3.2/go.mod h1:R3yVBYvzwqfOp26LidaiJ/zftVAnPC3pKunVpV/vosE=
+github.com/ralvarezdev/go-flags v0.3.3 h1:1NpwdSD+uCMF5NP+szJmq/mXqNFZwrzKAfDNZOznDEQ=
+github.com/ralvarezdev/go-flags v0.3.3/go.mod h1:R3yVBYvzwqfOp26LidaiJ/zftVAnPC3pKunVpV/vosE=
 github.com/ralvarezdev/go-logger v0.4.6 h1:eZalm0WAdNuhzbaVh5D7gC6AFztdpqE/GQfjH2pipyE=
 github.com/ralvarezdev/go-logger v0.4.6/go.mod h1:zxuMDHqtV2eoJYtmo219lima0ZSk4p/AGj/cCc390P8=
 github.com/ralvarezdev/go-reflect v0.2.4 h1:PLyzbrdNvUiRzpxSHuI9b7hJEhFes22gjNLZkbjn5AQ=
 github.com/ralvarezdev/go-reflect v0.2.4/go.mod h1:jv3EqQfUixWtNeJd/Rnzf0IDcYZ1z3GApRdAGQHdHZQ=
-github.com/ralvarezdev/go-strings v0.1.9 h1:FyYTJW+EnkWFp5C9GsK6wTt3rXIwPt3mUbsTAFUuAT8=
-github.com/ralvarezdev/go-strings v0.1.9/go.mod h1:8sFOqmPJpqzS7bTjf91EzUCITnwpmkfifwY80GxV5r8=
+github.com/ralvarezdev/go-strings v0.1.11 h1:3Vla7fGOs+4nyQ3NVaFz+XRP3CTv5JheGt0PXryBcMo=
+github.com/ralvarezdev/go-strings v0.1.11/go.mod h1:8sFOqmPJpqzS7bTjf91EzUCITnwpmkfifwY80GxV5r8=
diff --git a/struct/field/username/errors.go b/struct/field/username/errors.go
@@ -5,5 +5,5 @@ import (
 )
 
 var (
-	ErrFoundWhitespaces = errors.New("username cannot contain whitespaces")
+	ErrMustBeAlphanumeric = errors.New("username must be have alphanumeric characters")
 )
diff --git a/struct/mapper/validator/service.go b/struct/mapper/validator/service.go
@@ -134,11 +134,11 @@ func (d *DefaultService) Username(
 	username string,
 	validations *govalidatormappervalidation.StructValidations,
 ) {
-	// Check if the username contains a whitespace
-	if strings.Contains(username, " ") {
+	// Check if the username contains non-alphanumeric characters
+	if gostringscount.Alphanumeric(username) != len(username) {
 		validations.AddFieldValidationError(
 			usernameField,
-			govalidatorfieldusername.ErrFoundWhitespaces,
+			govalidatorfieldusername.ErrMustBeAlphanumeric,
 		)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@ import (`
`5`	`5`	`)`
`6`	`6`
`7`	`7`	`var (`
`8`		`- ErrFoundWhitespaces = errors.New("username cannot contain whitespaces")`
	`8`	`+ ErrMustBeAlphanumeric = errors.New("username must be have alphanumeric characters")`
`9`	`9`	`)`
Original file line number	Diff line number	Diff line change
`@@ -134,11 +134,11 @@ func (d *DefaultService) Username(`
`134`	`134`	`username string,`
`135`	`135`	`validations *govalidatormappervalidation.StructValidations,`
`136`	`136`	`) {`
`137`		`- // Check if the username contains a whitespace`
`138`		`- if strings.Contains(username, " ") {`
	`137`	`+ // Check if the username contains non-alphanumeric characters`
	`138`	`+ if gostringscount.Alphanumeric(username) != len(username) {`
`139`	`139`	`validations.AddFieldValidationError(`
`140`	`140`	`usernameField,`
`141`		`- govalidatorfieldusername.ErrFoundWhitespaces,`
	`141`	`+ govalidatorfieldusername.ErrMustBeAlphanumeric,`
`142`	`142`	`)`
`143`	`143`	`}`
`144`	`144`	`}`