Improve on Scroll double currentPage when shimmer running

Author: ramanaptr

app/src/main/java/com/ramanaptr/sample/MainActivity.kt

@@ -218,6 +218,8 @@ class MainActivity : AppCompatActivity() {
 
                 // Example handling data in single layout
                 val dataList = arrayListOf<SampleData>().apply {
+
+                     // if (currentPage >= 2) return@apply // limit the page for test stop populate the data
                     for (i in 1..size) {
                         add(SampleData("Key $i", "Value $i"))
                     }
@@ -257,7 +259,7 @@ class MainActivity : AppCompatActivity() {
                 // populate the data list
                 val dataList = arrayListOf<SampleData>().apply {
 
-                    // if (currentPage >= 2) return@apply // limit the page for test stop populate the data
+//                     if (currentPage >= 2) return@apply // limit the page for test stop populate the data
                     for (i in 1..size) {
 
                         // example handling data using ezViewType in layout 2
@@ -272,7 +274,7 @@ class MainActivity : AppCompatActivity() {
                         // example handling data using ezViewType in layout 1
                         // you must implement ezViewType because Ez-Recycler must to know attach the data into view you assign
                         val sampleDataOne =
-                            SampleData("Page ${currentPage + 1} \nKey $i", "\nValue $i")
+                            SampleData("Page ${currentPage + 1} \n\nKey $i", "\n\nValue $i")
                         sampleDataOne.ezViewType = EzViewType.LAYOUT_1
                         add(sampleDataOne)
                     }

ez-recyleview/src/main/java/com/ramanaptr/widget/EzRecyclerView.java

@@ -38,6 +38,7 @@ public class EzRecyclerView<Data extends EzBaseData> extends RecyclerView {
     private EzPaginationListener ezPaginationListener;
     private boolean isFirstLoadEzRecyclerView = true;
     private boolean isRecyclerViewLoading = false;
+    private boolean isShimmerRunning = false;
     private int tempShimmerSize = 0;
     private int startShimmerSize = 0;
     private int endShimmerSize = 0;
@@ -72,7 +73,7 @@ private void initComponent() {
 
     public void destroy() {
         flagEzRecyclerViewFirstLoad();
-        flagOnLoading();
+        flagOnStartLoading();
         removeOnScrollListener(onScrollListener);
         ezPaginationListener = null;
         baseAdapter = null;
@@ -87,7 +88,7 @@ public void destroy() {
     }
 
     /**
-     * we'll delete this method soon or not support
+     * we'll delete this method soon or not support in the future
      * Use instead #setData(Class)
      */
     @Deprecated
@@ -173,14 +174,15 @@ public void startShimmer(int shimmerSize) {
                 data.setEzViewType(EzViewType.SHIMMER_EFFECT);
                 shimmer.add(data);
             }
-            addAll(shimmer);
             flagEzRecyclerViewFirstLoadDone();
-            flagOnLoading();
+            flagOnStartLoading();
+            flagShimmerStart();
+            addAll(shimmer);
         }
     }
 
     /**
-     * we'll delete this method soon or not support
+     * we'll delete this method soon or not support in the future
      * Use instead #startShimmer(int) and use #setData(Class) before you start for shimmer effect
      */
     @Deprecated
@@ -197,81 +199,90 @@ public void startShimmer(int shimmerSize, Data data) {
                 data.setEzViewType(EzViewType.SHIMMER_EFFECT);
                 shimmer.add(data);
             }
-            addAll(shimmer);
             flagEzRecyclerViewFirstLoadDone();
-            flagOnLoading();
+            flagOnStartLoading();
+            addAll(shimmer);
         }
     }
 
     public void hideShimmer() {
         if (endShimmerSize > 0) {
-            baseAdapter.removeRange(startShimmerSize, (endShimmerSize + startShimmerSize), this);
+            baseAdapter.removeRange(startShimmerSize, (endShimmerSize + startShimmerSize));
             endShimmerSize = 0;
             endShimmerSize = tempShimmerSize;
             flagEzRecyclerViewFirstLoad();
+            flagShimmerStop();
+
+            // Remove all views when data list is zero
+            if (baseAdapter.getDataList().size() <= 0) {
+                removeAllViews();
+            }
         }
     }
 
     private void settingAnimator() {
     }
 
     public void add(@NonNull Data data) {
-        flagCompleteLoading();
+        flagStopLoading();
         baseAdapter.add(data);
     }
 
     public void addAll(@NonNull List<Data> dataList) {
-        if (dataList.size() <= 0) {
-            flagOnLoading();
-            currentPage = 0;
-            return;
-        }
-        flagCompleteLoading();
-        baseAdapter.addAll(dataList);
+        post(() -> {
+            if (dataList.size() <= 0) {
+                flagOnStartLoading();
+                currentPage = 0;
+                return;
+            }
+            flagStopLoading();
+            baseAdapter.addAll(dataList);
+        });
     }
 
     public void replace(@NonNull Data data) {
-        flagCompleteLoading();
+        flagStopLoading();
         baseAdapter.replace(data);
     }
 
     public void replaceAll(@NonNull List<Data> dataList) {
         if (dataList.size() <= 0) {
-            flagOnLoading();
+            flagOnStartLoading();
             currentPage = 0;
             return;
         }
-        flagCompleteLoading();
+        flagStopLoading();
         removeAllViews();
         baseAdapter.replaceAll(dataList);
     }
 
     public void remove(@NonNull int position) {
-        flagCompleteLoading();
+        flagStopLoading();
         removeViewAt(position);
         baseAdapter.remove(position);
     }
 
     public void remove(@NonNull Data data) {
-        flagCompleteLoading();
+        flagStopLoading();
         baseAdapter.remove(data);
     }
 
     public void removeAll() {
-        flagCompleteLoading();
+        flagStopLoading();
+        removeAllViews();
         baseAdapter.removeAll();
     }
 
     public void refresh() {
-        flagCompleteLoading();
+        flagStopLoading();
         baseAdapter.refresh();
     }
 
     public void resetAllViewsAndShimmer() {
         offset = 0;
         limit = 0;
         endShimmerSize = tempShimmerSize;
-        flagOnLoading();
+        flagOnStartLoading();
         flagEzRecyclerViewFirstLoad();
         removeAll();
         removeAllViews();
@@ -316,7 +327,7 @@ public void onScrolled(@NotNull RecyclerView recyclerView, int horizontalScrollS
                     pastVisibleItems = mLayoutManager.findFirstVisibleItemPosition();
                 }
 
-                if (!isRecyclerViewLoading) {
+                if (!isRecyclerViewLoading && !isShimmerRunning) {
                     if ((visibleItemCount + pastVisibleItems) >= totalItemCount) {
                         offset += limit;
                         currentPage++;
@@ -342,7 +353,7 @@ public void onScrolled(@NotNull RecyclerView recyclerView, int horizontalScrollS
                     pastVisibleItems = mLayoutManager.findFirstVisibleItemPosition();
                 }
 
-                if (!isRecyclerViewLoading) {
+                if (!isRecyclerViewLoading && !isShimmerRunning) {
                     if ((visibleItemCount + pastVisibleItems) >= totalItemCount) {
                         offset += limit;
                         currentPage++;
@@ -362,11 +373,19 @@ private void flagEzRecyclerViewFirstLoadDone() {
         isFirstLoadEzRecyclerView = false;
     }
 
-    public void flagCompleteLoading() {
+    public void flagStopLoading() {
         isRecyclerViewLoading = false;
     }
 
-    public void flagOnLoading() {
+    public void flagOnStartLoading() {
+        isShimmerRunning = true;
+    }
+
+    public void flagShimmerStop() {
+        isShimmerRunning = false;
+    }
+
+    public void flagShimmerStart() {
         isRecyclerViewLoading = true;
     }
 
@@ -499,14 +518,8 @@ public void removeRange(int min, int max) {
             notifyDataSetChanged();
         }
 
-        public void removeRange(int min, int max, EzRecyclerView<Data> ezRecyclerView) {
-            this.dataList.removeRange(min, max);
-            notifyDataSetChanged();
-
-            // Remove all views when data list is zero
-            if (dataList.size() <= 0) {
-                ezRecyclerView.removeAllViews();
-            }
+        public ListData<Data> getDataList() {
+            return dataList;
         }
 
         public void refresh() {