Merge pull request #58 from rameel/gcs-empty-stream-upload

rameel · web-flow · commit 7a529c589753 · 2026-03-26T00:30:40.000+05:00
Fix: allow creating empty object in GCS
diff --git a/src/Ramstack.FileSystem.Google/GcsWriteStream.cs b/src/Ramstack.FileSystem.Google/GcsWriteStream.cs
@@ -138,11 +138,8 @@ protected override void Dispose(bool disposing)
             {
                 _stream.Position = 0;
 
-                if (_stream.Length != 0)
-                {
-                    var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
-                    _fs.StorageClient.UploadObject(destination, _stream);
-                }
+                var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
+                _fs.StorageClient.UploadObject(destination, _stream);
             }
             finally
             {
@@ -163,14 +160,11 @@ public override async ValueTask DisposeAsync()
             {
                 _stream.Position = 0;
 
-                if (_stream.Length != 0)
-                {
-                    var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
+                var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
 
-                    await _fs.StorageClient
-                        .UploadObjectAsync(destination, _stream)
-                        .ConfigureAwait(false);
-                }
+                await _fs.StorageClient
+                    .UploadObjectAsync(destination, _stream)
+                    .ConfigureAwait(false);
             }
             finally
             {

Original file line number	Diff line number	Diff line change
`@@ -138,11 +138,8 @@ protected override void Dispose(bool disposing)`
`138`	`138`	`{`
`139`	`139`	`_stream.Position = 0;`
`140`	`140`
`141`		`- if (_stream.Length != 0)`
`142`		`- {`
`143`		`- var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };`
`144`		`- _fs.StorageClient.UploadObject(destination, _stream);`
`145`		`- }`
	`141`	`+ var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };`
	`142`	`+ _fs.StorageClient.UploadObject(destination, _stream);`
`146`	`143`	`}`
`147`	`144`	`finally`
`148`	`145`	`{`
`@@ -163,14 +160,11 @@ public override async ValueTask DisposeAsync()`
`163`	`160`	`{`
`164`	`161`	`_stream.Position = 0;`
`165`	`162`
`166`		`- if (_stream.Length != 0)`
`167`		`- {`
`168`		`- var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };`
	`163`	`+ var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };`
`169`	`164`
`170`		`- await _fs.StorageClient`
`171`		`- .UploadObjectAsync(destination, _stream)`
`172`		`- .ConfigureAwait(false);`
`173`		`- }`
	`165`	`+ await _fs.StorageClient`
	`166`	`+ .UploadObjectAsync(destination, _stream)`
	`167`	`+ .ConfigureAwait(false);`
`174`	`168`	`}`
`175`	`169`	`finally`
`176`	`170`	`{`