Merge pull request #1 from rameerez/cursor/ensure-gem-is-fully-tested-and-robust-29e7

Add full Minitest 6 testing suite

Author: rameerez

.github/workflows/test.yml

@@ -0,0 +1,53 @@
+name: Tests
+
+on:
+  pull_request:
+    paths-ignore:
+      - "*.md"
+      - "LICENSE.txt"
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - "*.md"
+      - "LICENSE.txt"
+
+jobs:
+  # Main test suite - tests Ruby versions and Rails compatibility
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby_version: ["3.3", "3.4", "4.0"]
+        gemfile:
+          - Gemfile
+          - gemfiles/rails_7.2.gemfile
+          - gemfiles/rails_8.0.gemfile
+          - gemfiles/rails_8.1.gemfile
+
+    env:
+      RAILS_ENV: test
+      BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Ruby ${{ matrix.ruby_version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rake test
+
+      - name: Upload test results
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: test-results-sqlite-ruby-${{ matrix.ruby_version }}-${{ matrix.gemfile }}
+          path: test/reports/
+          retention-days: 7

.simplecov

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# SimpleCov configuration file (auto-loaded before test suite)
+# This keeps test_helper.rb clean and follows best practices
+
+SimpleCov.start do
+  # Use SimpleFormatter for terminal-only output (no HTML generation)
+  formatter SimpleCov::Formatter::SimpleFormatter
+
+  # Track coverage for the lib directory (gem source code)
+  add_filter "/test/"
+
+  # Track the lib and app directories
+  track_files "{lib,app}/**/*.rb"
+
+  # Enable branch coverage for more detailed metrics
+  enable_coverage :branch
+
+  # Set minimum coverage threshold to prevent coverage regression
+  minimum_coverage line: 90, branch: 90
+
+  # Disambiguate parallel test runs
+  command_name "Job #{ENV['TEST_ENV_NUMBER']}" if ENV['TEST_ENV_NUMBER']
+end
+
+# Print coverage summary to terminal after tests complete
+SimpleCov.at_exit do
+  SimpleCov.result.format!
+  puts "\n" + "=" * 60
+  puts "COVERAGE SUMMARY"
+  puts "=" * 60
+  puts "Line Coverage:   #{SimpleCov.result.covered_percent.round(2)}%"
+  puts "Branch Coverage: #{SimpleCov.result.coverage_statistics[:branch]&.percent&.round(2) || 'N/A'}%"
+  puts "=" * 60
+end

Appraisals

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# Note: Rails < 7.2 is not compatible with Ruby 3.4
+# (Logger became a bundled gem in Ruby 3.4, and only Rails 7.2+ handles this)
+# See: https://stdgems.org/logger/
+
+# Test against Rails 7.2 (minimum version compatible with Ruby 3.4)
+appraise "rails-7.2" do
+  gem "rails", "~> 7.2.0"
+end
+
+# Test against Rails 8.0
+appraise "rails-8.0" do
+  gem "rails", "~> 8.0.0"
+end
+
+# Test against Rails 8.1 (latest)
+appraise "rails-8.1" do
+  gem "rails", "~> 8.1.2"
+end

Gemfile

@@ -6,3 +6,13 @@ source "https://rubygems.org"
 gemspec
 
 gem "rake", "~> 13.0"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end

Rakefile

@@ -1,4 +1,13 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-task default: %i[]
+require "rake/testtask"
+
+Rake::TestTask.new(:test) do |t|
+  t.libs << "lib"
+  t.libs << "test"
+  t.test_files = FileList['test/**/*_test.rb']
+  t.warning = false
+end
+
+task default: %i[test]

gemfiles/rails_7.2.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 7.2.0"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

gemfiles/rails_8.0.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.0.0"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

gemfiles/rails_8.1.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.1.2"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

lib/nondisposable.rb

@@ -19,8 +19,9 @@ def self.configure
 
   def self.disposable?(email)
     return false if email.nil? || !email.include?('@')
-    domain = email.to_s.split('@').last.downcase
-    DisposableDomain.disposable?(domain)
+    domain = email.to_s.split('@').last
+    return false if domain.nil? || domain.empty?
+    DisposableDomain.disposable?(domain.downcase)
   end
 
   class Configuration

lib/nondisposable/engine.rb

@@ -4,10 +4,6 @@ module Nondisposable
   class Engine < ::Rails::Engine
     isolate_namespace Nondisposable
 
-    initializer "nondisposable.assets.precompile" do |app|
-      app.config.assets.precompile += %w( nondisposable/application.css nondisposable/application.js )
-    end
-
     config.generators do |g|
       g.test_framework :rspec
       g.fixture_replacement :factory_bot