Add test suite and configuration for Nondisposable gem

Co-authored-by: jaracursorsh <jaracursorsh@mitomail.com>

Author: cursoragent

.gitignore

@@ -7,5 +7,6 @@
 /spec/reports/
 /tmp/
 /dist/
+/vendor/
 
 TODO

Gemfile

@@ -6,3 +6,11 @@ source "https://rubygems.org"
 gemspec
 
 gem "rake", "~> 13.0"
+
+group :test do
+  gem "minitest", "~> 5.22"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 1.4"
+  gem "simplecov", "~> 0.22", require: false
+end

Gemfile.lock

@@ -3,7 +3,6 @@ PATH
   specs:
     nondisposable (0.1.0)
       rails (>= 7.0.0)
-      whenever (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -78,18 +77,25 @@ GEM
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
+    ansi (1.5.0)
     base64 (0.2.0)
     bigdecimal (3.1.8)
     builder (3.3.0)
-    chronic (0.10.2)
     concurrent-ruby (1.3.4)
     connection_pool (2.4.1)
+    crack (1.0.0)
+      bigdecimal
+      rexml
     crass (1.0.6)
     date (3.3.4)
+    docile (1.4.1)
     drb (2.2.1)
     erubi (1.13.0)
     globalid (1.2.1)
       activesupport (>= 6.1)
+    hashdiff (1.2.0)
     i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     io-console (0.7.2)
@@ -108,6 +114,11 @@ GEM
     marcel (1.0.4)
     mini_mime (1.1.5)
     minitest (5.25.1)
+    minitest-reporters (1.7.1)
+      ansi
+      builder
+      minitest (>= 5.0)
+      ruby-progressbar
     net-imap (0.5.0)
       date
       net-protocol
@@ -132,6 +143,7 @@ GEM
       racc (~> 1.4)
     psych (5.1.2)
       stringio
+    public_suffix (6.0.2)
     racc (1.8.1)
     rack (3.1.8)
     rack-session (2.0.0)
@@ -175,19 +187,35 @@ GEM
       psych (>= 4.0.0)
     reline (0.5.10)
       io-console (~> 0.5)
+    rexml (3.4.1)
+    ruby-progressbar (1.13.0)
     securerandom (0.3.1)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.2)
+    simplecov_json_formatter (0.1.4)
+    sqlite3 (1.7.3-aarch64-linux)
+    sqlite3 (1.7.3-arm-linux)
+    sqlite3 (1.7.3-arm64-darwin)
+    sqlite3 (1.7.3-x86-linux)
+    sqlite3 (1.7.3-x86_64-darwin)
+    sqlite3 (1.7.3-x86_64-linux)
     stringio (3.1.1)
     thor (1.3.2)
     timeout (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     useragent (0.16.10)
+    webmock (3.25.1)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
     webrick (1.8.2)
     websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    whenever (1.0.0)
-      chronic (>= 0.6.3)
     zeitwerk (2.7.1)
 
 PLATFORMS
@@ -199,8 +227,13 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
+  minitest (~> 5.22)
+  minitest-reporters (~> 1.6)
   nondisposable!
   rake (~> 13.0)
+  simplecov (~> 0.22)
+  sqlite3 (~> 1.4)
+  webmock (~> 3.19)
 
 BUNDLED WITH
    2.5.22

Rakefile

@@ -1,4 +1,13 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-task default: %i[]
+require "rake/testtask"
+
+Rake::TestTask.new(:test) do |t|
+  t.libs << "lib"
+  t.libs << "test"
+  t.test_files = FileList['test/**/*_test.rb']
+  t.warning = false
+end
+
+task default: %i[test]

test/nondisposable/configuration_test.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ConfigurationTest < Minitest::Test
+  def setup
+    Nondisposable.configuration = Nondisposable::Configuration.new
+    Nondisposable::DisposableDomain.delete_all
+  end
+
+  def test_configuration_defaults
+    config = Nondisposable.configuration
+    assert_equal "provider is not allowed", config.error_message
+    assert_equal [], config.additional_domains
+    assert_equal [], config.excluded_domains
+  end
+
+  def test_configure_block
+    Nondisposable.configure do |c|
+      c.error_message = "blocked"
+      c.additional_domains = ["added.com"]
+      c.excluded_domains = ["excluded.com"]
+    end
+
+    config = Nondisposable.configuration
+    assert_equal "blocked", config.error_message
+    assert_equal ["added.com"], config.additional_domains
+    assert_equal ["excluded.com"], config.excluded_domains
+  end
+
+  def test_disposable_query_helper_method
+    Nondisposable::DisposableDomain.create!(name: "bad.com")
+    assert Nondisposable.disposable?("user@bad.com")
+    refute Nondisposable.disposable?("user@good.com")
+    refute Nondisposable.disposable?(nil)
+    refute Nondisposable.disposable?("nogood")
+  end
+end

test/nondisposable/disposable_domain_model_test.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DisposableDomainModelTest < Minitest::Test
+  def setup
+    Nondisposable.configuration = Nondisposable::Configuration.new
+    Nondisposable::DisposableDomain.delete_all
+  end
+
+  def test_validates_presence_and_uniqueness_case_insensitive
+    d1 = Nondisposable::DisposableDomain.create!(name: "TempMail.com")
+    d2 = Nondisposable::DisposableDomain.new(name: "tempmail.com")
+
+    refute d2.valid?
+    assert_includes d2.errors[:name], "has already been taken"
+
+    d1.update!(name: "new.com")
+    d2.name = "tempmail.com"
+  end
+
+  def test_disposable_query_with_blank
+    refute Nondisposable::DisposableDomain.disposable?(nil)
+    refute Nondisposable::DisposableDomain.disposable?("")
+  end
+
+  def test_disposable_query_true_when_in_db
+    Nondisposable::DisposableDomain.create!(name: "foo.com")
+    assert Nondisposable::DisposableDomain.disposable?("foo.com")
+    assert Nondisposable::DisposableDomain.disposable?("FOO.COM"), "should be case-insensitive"
+  end
+
+  def test_disposable_query_true_when_in_additional_domains
+    Nondisposable.configuration.additional_domains = ["bar.com"]
+    assert Nondisposable::DisposableDomain.disposable?("bar.com")
+  end
+
+  def test_disposable_query_false_when_excluded
+    Nondisposable::DisposableDomain.create!(name: "baz.com")
+    Nondisposable.configuration.excluded_domains = ["baz.com"]
+    refute Nondisposable::DisposableDomain.disposable?("baz.com")
+  end
+end

test/nondisposable/domain_list_updater_test.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DomainListUpdaterTest < Minitest::Test
+  def setup
+    Nondisposable.configuration = Nondisposable::Configuration.new
+    Nondisposable::DisposableDomain.delete_all
+  end
+
+  def test_successfully_updates_domains_from_remote
+    body = "temp.com\ntrash.net\n"
+    stub = stub_request(:get, %r{raw\.githubusercontent\.com/.*/disposable_email_blocklist\.conf}).to_return(status: 200, body: body)
+
+    assert Nondisposable::DomainListUpdater.update
+    assert_requested stub
+    names = Nondisposable::DisposableDomain.order(:name).pluck(:name)
+    assert_equal %w[temp.com trash.net], names
+  end
+
+  def test_merges_additional_and_excluded_domains
+    Nondisposable.configuration.additional_domains = ["extra.com", "trash.net"]
+    Nondisposable.configuration.excluded_domains = ["trash.net"]
+
+    body = "temp.com\ntrash.net\n"
+    stub_request(:get, /disposable-email-domains/).to_return(status: 200, body: body)
+
+    assert Nondisposable::DomainListUpdater.update
+    names = Nondisposable::DisposableDomain.order(:name).pluck(:name)
+    assert_equal %w[extra.com temp.com], names
+  end
+
+  def test_returns_false_on_http_failure
+    stub_request(:get, /disposable-email-domains/).to_return(status: 500, body: "")
+
+    refute Nondisposable::DomainListUpdater.update
+    assert_equal 0, Nondisposable::DisposableDomain.count
+  end
+
+  def test_returns_false_on_empty_list
+    stub_request(:get, /disposable-email-domains/).to_return(status: 200, body: "\n\n")
+
+    refute Nondisposable::DomainListUpdater.update
+    assert_equal 0, Nondisposable::DisposableDomain.count
+  end
+
+  def test_returns_false_on_network_error
+    stub_request(:get, /disposable-email-domains/).to_raise(SocketError.new("no network"))
+
+    refute Nondisposable::DomainListUpdater.update
+    assert_equal 0, Nondisposable::DisposableDomain.count
+  end
+
+  def test_transactionality_deletes_then_inserts
+    body = "a.com\nb.com\n"
+    stub_request(:get, /disposable-email-domains/).to_return(status: 200, body: body)
+
+    Nondisposable::DisposableDomain.create!(name: "old.com")
+    assert Nondisposable::DomainListUpdater.update
+    refute Nondisposable::DisposableDomain.exists?(name: "old.com")
+    assert_equal %w[a.com b.com], Nondisposable::DisposableDomain.order(:name).pluck(:name)
+  end
+
+  def test_update_rolls_back_on_insert_error
+    # Pre-populate with a domain that should remain if the transaction rolls back
+    Nondisposable::DisposableDomain.create!(name: "keep.com")
+
+    body = "a.com\n"
+    stub_request(:get, /disposable-email-domains/).to_return(status: 200, body: body)
+
+    Nondisposable::DisposableDomain.stub(:create, proc { raise "insert failed" }) do
+      refute Nondisposable::DomainListUpdater.update
+    end
+
+    # Ensure rollback kept the original data
+    assert_equal %w[keep.com], Nondisposable::DisposableDomain.order(:name).pluck(:name)
+  end
+end

test/nondisposable/email_validator_test.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class NondisposableValidatorTest < Minitest::Test
+  def setup
+    Nondisposable.configuration = Nondisposable::Configuration.new
+    Nondisposable::DisposableDomain.delete_all
+  end
+
+  def test_allows_blank_values
+    # Use a model without presence validation to isolate validator behavior
+    klass = Class.new(ApplicationRecord) do
+      self.table_name = "users"
+      validates :email, nondisposable: true
+    end
+    user = klass.new(email: "")
+    assert user.valid?, "Blank emails should be allowed by validator (presence handled elsewhere)"
+  end
+
+  def test_allows_invalid_format_without_at_symbol
+    user = User.new(email: "invalid-email")
+    # The validator returns if domain is nil (no '@'), so no error should be added here
+    assert user.valid?, "Validator should skip invalid formats without adding errors"
+  end
+
+  def test_blocks_disposable_domain
+    Nondisposable::DisposableDomain.create!(name: "trashmail.com")
+    user = User.new(email: "foo@trashmail.com")
+    refute user.valid?
+    assert_includes user.errors[:email], Nondisposable.configuration.error_message
+  end
+
+  def test_blocks_additional_configured_domain_even_if_not_in_db
+    Nondisposable.configuration.additional_domains = ["tempmail.com"]
+    user = User.new(email: "bar@tempmail.com")
+    refute user.valid?
+    assert_includes user.errors[:email], Nondisposable.configuration.error_message
+  end
+
+  def test_allows_excluded_domains_even_if_in_db
+    Nondisposable::DisposableDomain.create!(name: "filter.com")
+    Nondisposable.configuration.excluded_domains = ["filter.com"]
+    user = User.new(email: "ok@filter.com")
+    assert user.valid?
+  end
+
+  def test_custom_error_message
+    Nondisposable::DisposableDomain.create!(name: "spam.io")
+    custom_message = "is a disposable email address, please use a permanent email address."
+    user = Class.new(User) do
+      validates :email, nondisposable: { message: "is a disposable email address, please use a permanent email address." }
+    end.new(email: "u@spam.io")
+
+    refute user.valid?
+    assert_includes user.errors[:email], custom_message
+  end
+
+  def test_error_handling_logs_and_adds_fallback_error
+    # Stub out DisposableDomain.disposable? to raise and ensure fallback error is added
+    Nondisposable::DisposableDomain.stub(:disposable?, proc { raise "boom" }) do
+      user = User.new(email: "x@y.com")
+      refute user.valid?
+      assert_includes user.errors[:email], "is an invalid email address, cannot check if it's disposable"
+    end
+  end
+
+  def test_uppercase_email_is_handled
+    Nondisposable::DisposableDomain.create!(name: "bad.com")
+    user = User.new(email: "USER@BAD.COM")
+    refute user.valid?
+  end
+
+  def test_helper_method_validates_nondisposable_email
+    klass = Class.new(ApplicationRecord) do
+      self.table_name = "users"
+      extend ActiveModel::Validations::HelperMethods
+      validates_nondisposable_email :email
+    end
+    Nondisposable::DisposableDomain.create!(name: "helper.com")
+    user = klass.new(email: "x@helper.com")
+    refute user.valid?
+  end
+end