Fix object validation error when input is not an array (#158)

Author: nofirg

src/Types/ObjectType.php

@@ -111,7 +111,7 @@ public static function createFromArray($name, array $data = [])
      */
     public function discriminate($value)
     {
-        if (isset($value[$this->getDiscriminator()])) {
+        if (\is_array($value) && isset($value[$this->getDiscriminator()])) {
             if ($this->getDiscriminatorValue() !== null) {
                 return $this->getDiscriminatorValue() === $value[$this->getDiscriminator()];
             }

tests/Types/ObjectTypeTest.php

@@ -0,0 +1,59 @@
+<?php
+
+namespace Raml\Tests\Types;
+
+use PHPUnit\Framework\TestCase;
+use Raml\ApiDefinition;
+use Raml\Parser;
+use Raml\Types\TypeValidationError;
+
+class ObjectTypeTest extends TestCase
+{
+    /**
+     * @var ApiDefinition
+     */
+    private $apiDefinition;
+
+    protected function setUp()
+    {
+        parent::setUp();
+        $this->apiDefinition = (new Parser())->parse(__DIR__ . '/../fixture/object_types.raml');
+    }
+
+    /**
+     * @test
+     */
+    public function shouldCorrectlyValidateCorrectType()
+    {
+        $resource = $this->apiDefinition->getResourceByUri('/actors/1');
+        $method = $resource->getMethod('get');
+        $response = $method->getResponse(200);
+        $body = $response->getBodyByType('application/json');
+        $type = $body->getType();
+
+        $type->validate([
+            'fistName' => 'Jackie',
+            'lastName' => 'Сhan',
+        ]);
+
+        $this->assertTrue($type->isValid());
+    }
+
+    /**
+     * @test
+     */
+    public function shouldNotCorrectlyValidateObjectType()
+    {
+        $resource = $this->apiDefinition->getResourceByUri('/actors/1');
+        $method = $resource->getMethod('get');
+        $response = $method->getResponse(200);
+        $body = $response->getBodyByType('application/json');
+        $type = $body->getType();
+
+        $type->validate('Jackie Сhan');
+
+        $this->assertFalse($type->isValid());
+        $this->assertCount(1, $type->getErrors());
+        $this->assertInstanceOf(TypeValidationError::class, $type->getErrors()[0]);
+    }
+}

tests/fixture/object_types.raml

@@ -0,0 +1,23 @@
+#%RAML 1.0
+
+title: List of actors API
+baseUri: http://example.api.com/{version}
+version: v1
+mediaType: application/json
+
+/actors/{id}:
+  get:
+    responses:
+      200:
+        body:
+          application/json:
+            type: Actor
+types:
+  Actor:
+    properties:
+      fistName:
+        type: string
+        required: true
+      lastName:
+        type: string
+        required: true