Skip to content

Commit 5c39930

Browse files
committed
Remove use of html-fill-item-overflow-hidden class
1 parent d31dd27 commit 5c39930

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

DESCRIPTION

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@ URL: https://github.com/ramnathv/htmlwidgets
2121
BugReports: https://github.com/ramnathv/htmlwidgets/issues
2222
Imports:
2323
grDevices,
24-
htmltools (>= 0.5.4),
24+
htmltools (>= 0.5.4.9000),
2525
jsonlite (>= 0.9.16),
2626
knitr (>= 1.8),
2727
rmarkdown,
2828
yaml
2929
Suggests:
3030
testthat
31+
Remotes:
32+
rstudio/htmltools
3133
Enhances:
3234
shiny (>= 1.1)
3335
VignetteBuilder:

R/htmlwidgets.R

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,7 @@ toHTML <- function(x, standalone = FALSE, knitrOptions = NULL) {
183183
width = validateCssUnit(sizeInfo$width),
184184
height = validateCssUnit(sizeInfo$height),
185185
),
186-
class = paste(
187-
name, "html-widget",
188-
# bindFillRole() puts `overflow:auto` to items by default,
189-
# which is a sensible generic default, but in the context of
190-
# widgets, we can pretty easily run into non-pixel-perfect situations
191-
# (e.g., the widget JS uses something like offsetHeight to resize itself)
192-
if (sizeInfo$fill) "html-fill-item-overflow-hidden"
193-
),
186+
class = paste(name, "html-widget"),
194187
width = sizeInfo$width,
195188
height = sizeInfo$height
196189
)
@@ -488,12 +481,7 @@ shinyWidgetOutput <- function(outputId, name, width, height, package = name,
488481
class = paste0(
489482
name, " html-widget html-widget-output",
490483
if (reportSize) " shiny-report-size",
491-
if (reportTheme) " shiny-report-theme",
492-
# bindFillRole() puts `overflow:auto` to items by default,
493-
# which is a sensible generic default, but in the context of
494-
# widgets, we can pretty easily run into non-pixel-perfect situations
495-
# (e.g., the widget JS uses something like offsetHeight to resize itself)
496-
if (fill) " html-fill-item-overflow-hidden"
484+
if (reportTheme) " shiny-report-theme"
497485
),
498486
style = css(
499487
width = validateCssUnit(width),

0 commit comments

Comments
 (0)