Skip to content

Commit eea3bb3

Browse files
authored
fix: use hardcoded checksum for minisign verification (#16)
* fix: use hardcoded checksum for minisign verification The minisign releases provide .minisig signature files, not .sha256 checksums. This fix uses a hardcoded SHA256 checksum to verify the minisign binary download since the .sha256 file doesn't exist at the expected GitHub URL. * fix: add concurrency control to prevent duplicate CI runs Add concurrency groups to CI and Security workflows to prevent duplicate runs when PRs are created and merged. The workflows will now cancel in-progress runs when new commits are pushed, saving CI resources.
1 parent 77ae8f8 commit eea3bb3

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ on:
77
branches: [ "main" ]
88
workflow_dispatch:
99

10+
concurrency:
11+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
12+
cancel-in-progress: true
13+
1014
permissions:
1115
contents: read
1216

.github/workflows/publish.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,11 @@ jobs:
6666
run: |
6767
# Download minisign with checksum verification
6868
curl -LO https://github.com/jedisct1/minisign/releases/download/0.12/minisign-0.12-linux.tar.gz
69-
curl -LO https://github.com/jedisct1/minisign/releases/download/0.12/minisign-0.12-linux.tar.gz.sha256
70-
# Fix checksum format (file contains only hash, not "hash filename" format)
71-
echo "$(cat minisign-0.12-linux.tar.gz.sha256) minisign-0.12-linux.tar.gz" > minisign-0.12-linux.tar.gz.sha256
72-
sha256sum -c minisign-0.12-linux.tar.gz.sha256
69+
# Verify against known checksum (minisign doesn't provide .sha256 files, only .minisig signatures)
70+
echo "9a599b48ba6eb7b1e80f12f36b94ceca7c00b7a5173c95c3efc88d9822957e73 minisign-0.12-linux.tar.gz" | sha256sum -c
7371
tar xzf minisign-0.12-linux.tar.gz
7472
sudo mv minisign-linux/x86_64/minisign /usr/local/bin/
75-
rm -f minisign-0.12-linux.tar.gz minisign-0.12-linux.tar.gz.sha256
73+
rm -f minisign-0.12-linux.tar.gz
7674
7775
- name: Setup minisign keys
7876
run: |

.github/workflows/security.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ on:
88
schedule:
99
- cron: '0 6 * * 1' # Weekly on Monday at 6 AM UTC
1010

11+
concurrency:
12+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
13+
cancel-in-progress: true
14+
1115
permissions:
1216
contents: read
1317

0 commit comments

Comments
 (0)