Add warnings and strict_warnings interfaces

Author: ramsafin

CMakeLists.txt

@@ -8,17 +8,21 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 # Export compile_commands.json for clangd and clang-tidy
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
-# Add custom "Sanitize" build type for multi-config generators (e.g., Visual Studio)
+# Add custom "Sanitize" build type
 if(CMAKE_CONFIGURATION_TYPES)
   list(APPEND CMAKE_CONFIGURATION_TYPES Sanitize)
   list(REMOVE_DUPLICATES CMAKE_CONFIGURATION_TYPES)
   set(CMAKE_CONFIGURATION_TYPES "${CMAKE_CONFIGURATION_TYPES}" CACHE STRING "" FORCE)
 endif()
 
-# Load sanitizer flags if needed
+# Load sanitizers
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
 include(Sanitizers)
 
+# Load warnings
+list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
+include(Warnings)
+
 # === Libraries ===
 add_subdirectory(src)
 
@@ -31,13 +35,13 @@ target_link_libraries(${PROJECT_NAME}
   PRIVATE arithmetic
 )
 
+enable_strict_warnings(${PROJECT_NAME})
 target_link_with_sanitizers(${PROJECT_NAME})
 
 # === Unit Testing ===
 option(ENABLE_TESTING "Build tests" ON)
 
 if(ENABLE_TESTING)
-  message(STATUS "✅ Enabled unit tests")
   enable_testing()
   add_subdirectory(tests)
 endif()

cmake/Sanitizers.cmake

@@ -10,13 +10,12 @@ if(CMAKE_BUILD_TYPE STREQUAL "Sanitize")
   add_library(sanitizers INTERFACE)
   target_compile_options(sanitizers INTERFACE ${SANITIZER_FLAGS})
   target_link_options(sanitizers INTERFACE ${SANITIZER_FLAGS})
-
   message(STATUS "✅ Sanitize build: enabled with flags: ${SANITIZER_FLAGS}")
 endif()
 
 function(target_link_with_sanitizers target)
   if(TARGET sanitizers)
-    message(STATUS "✅ Enabled sanitizers for target ${target}")
-    target_link_libraries(${target} PRIVATE sanitizers)
+  target_link_libraries(${target} PRIVATE sanitizers)
+  message(STATUS "✅ Enabled sanitizers for target ${target}")
   endif()
 endfunction()

cmake/Warnings.cmake

@@ -0,0 +1,32 @@
+# Standard warnings
+add_library(warnings INTERFACE)
+
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+  target_compile_options(warnings INTERFACE
+    -Wall
+    -Wextra
+    -Wpedantic
+    -Wconversion
+    -Wsign-conversion
+  )
+endif()
+
+# Warnings as errors
+add_library(strict_warnings INTERFACE)
+
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+  target_compile_options(strict_warnings INTERFACE -Werror)
+  target_link_libraries(strict_warnings PRIVATE warnings)
+endif()
+
+# Function to apply warnings
+function(enable_warnings target)
+  target_link_libraries(${target} PRIVATE warnings)
+  message(STATUS "⚠️ Enabled warnings for target ${target}")
+endfunction()
+
+# Function to apply warnings as errors
+function(enable_strict_warnings target)
+  target_link_libraries(${target} PRIVATE strict_warnings)
+  message(STATUS "⚠️ Enabled warnings as errors for target ${target}")
+endfunction()

src/CMakeLists.txt

@@ -6,4 +6,5 @@ target_include_directories(arithmetic
   PUBLIC ${PROJECT_SOURCE_DIR}/include
 )
 
+enable_strict_warnings(arithmetic)
 target_link_with_sanitizers(arithmetic)

tests/CMakeLists.txt

@@ -22,6 +22,7 @@ target_link_libraries(unit_tests
   PRIVATE gtest_main arithmetic
 )
 
+enable_warnings(unit_tests)
 target_link_with_sanitizers(unit_tests)
 
 # Automatically discover and register all test cases