opt: only re-train the model with new message rather than all messages

Author: ramsayleung

app/jobs/classifier_trainer_job.rb

@@ -2,10 +2,18 @@ class ClassifierTrainerJob < ApplicationJob
   # Job to train classifier asynchronously
   queue_as :training
 
-  def perform(group_id, group_name)
+  def perform(trained_message)
     Rails.logger.info "Retrain all the classifiers for public"
-    GroupClassifierState.for_public.find_each do |classifier|
-      SpamClassifierService.rebuild_for_group(classifier.group_id, classifier.group_name)
+    if trained_message.user_name?
+      GroupClassifierState.username.find_each do |classifier|
+        spam_classifier = SpamClassifierService.new(classifier.group_id, classifier.group_name)
+        spam_classifier.train(trained_message)
+      end
+    elsif trained_message.message_content?
+      GroupClassifierState.for_group.find_each do |classifier|
+        spam_classifier = SpamClassifierService.new(classifier.group_id, classifier.group_name)
+        spam_classifier.train(trained_message)
+      end
     end
   end
 end

app/models/trained_message.rb

@@ -58,13 +58,7 @@ def should_ban_user
   def retrain_classifier
     return if untrained?
 
-    if user_name?
-      # Target is user_name
-      ClassifierTrainerJob.perform_later(GroupClassifierState::USER_NAME_CLASSIFIER_GROUP_ID, GroupClassifierState::USER_NAME_CLASSIFIER_GROUP_NAME)
-    else
-      # For efficiency, we could queue this as a background job
-      ClassifierTrainerJob.perform_later(group_id, group_name)
-    end
+    ClassifierTrainerJob.perform_later(self)
   end
 
   private

app/views/group_classifier_states/index.html.erb

@@ -66,6 +66,14 @@
                 <% end %>
               <% end %>
             </th>
+            <th scope="col" class="px-6 py-3 text-left text-xs font-medium text-gray-500 uppercase tracking-wider">
+              <%= link_to group_classifier_states_path(params.permit!.merge(sort: 'updated_at', direction: params[:sort] == 'updated_at' && params[:direction] == 'asc' ? 'desc' : 'asc')), class: "hover:text-gray-700 flex items-center space-x-1" do %>
+                <span>Updated</span>
+                <% if params[:sort] == 'updated_at' %>
+                  <span><%= params[:direction] == 'asc' ? '↑' : '↓' %></span>
+                <% end %>
+              <% end %>
+            </th>
             <th scope="col" class="relative px-6 py-3">
               <span class="sr-only">Actions</span>
             </th>
@@ -106,6 +114,10 @@
                   <%= time_ago_in_words(group_classifier_state.created_at) %> ago
                 </td>
 
+                <td class="px-6 py-4 whitespace-nowrap text-sm text-gray-500">
+                  <%= time_ago_in_words(group_classifier_state.updated_at) %> ago
+                </td>
+
                 <td class="px-6 py-4 whitespace-nowrap text-right text-sm font-medium">
                   <div class="flex space-x-2">
                     <%= link_to "View", group_classifier_state_path(group_classifier_state, request.query_parameters), class: "text-indigo-600 hover:text-indigo-900" %>