fix failed tests

Author: ramsayleung

app/services/telegram_member_fetcher.rb

@@ -1,3 +1,5 @@
+require "telegram/bot"
+
 class TelegramMemberFetcher
   def self.get_bot_chat_member(group_id)
     bot_id = Rails.cache.fetch("bot_id", expires_in: 24.hours) do

test/controllers/group_classifier_states_controller_test.rb

@@ -17,7 +17,15 @@ class GroupClassifierStatesControllerTest < ActionDispatch::IntegrationTest
 
   test "should create group_classifier_state" do
     assert_difference("GroupClassifierState.count") do
-      post group_classifier_states_url, params: { group_classifier_state: { group_id: @group_classifier_state.group_id, ham_counts: @group_classifier_state.ham_counts, spam_counts: @group_classifier_state.spam_counts, total_ham_messages: @group_classifier_state.total_ham_messages, total_ham_words: @group_classifier_state.total_ham_words, total_spam_messages: @group_classifier_state.total_spam_messages, total_spam_words: @group_classifier_state.total_spam_words, vocabulary_size: @group_classifier_state.vocabulary_size } }
+      post group_classifier_states_url, params: { group_classifier_state:
+                                                  { group_id: 99,
+                                                    ham_counts: @group_classifier_state.ham_counts,
+                                                    spam_counts: @group_classifier_state.spam_counts,
+                                                    total_ham_messages: @group_classifier_state.total_ham_messages,
+                                                    total_ham_words: @group_classifier_state.total_ham_words,
+                                                    total_spam_messages: @group_classifier_state.total_spam_messages,
+                                                    total_spam_words: @group_classifier_state.total_spam_words,
+                                                    vocabulary_size: @group_classifier_state.vocabulary_size } }
     end
 
     assert_redirected_to group_classifier_state_url(GroupClassifierState.last)

test/controllers/trained_messages_controller_test.rb

@@ -17,7 +17,13 @@ class TrainedMessagesControllerTest < ActionDispatch::IntegrationTest
 
   test "should create trained_message" do
     assert_difference("TrainedMessage.count") do
-      post trained_messages_url, params: { trained_message: { group_id: @trained_message.group_id, message: @trained_message.message, message_type: @trained_message.message_type, sender_chat_id: @trained_message.sender_chat_id } }
+      TelegramMemberFetcher.stub(:get_bot_chat_member, OpenStruct.new(status: "administrator", can_restrict_members: true)) do
+        post trained_messages_url, params: { trained_message: {
+                                               group_id: @trained_message.group_id,
+                                               message: @trained_message.message,
+                                               message_type: @trained_message.message_type,
+                                               sender_chat_id: @trained_message.sender_chat_id } }
+      end
     end
 
     assert_redirected_to trained_message_url(TrainedMessage.last)

test/fixtures/group_classifier_states.yml

@@ -11,7 +11,7 @@ one:
   vocabulary_size: 1
 
 two:
-  group_id: 1
+  group_id: 2
   spam_counts: '{"word5": 2, "word6": 8}'
   ham_counts: '{"word7": 4, "word8": 6}'
   total_spam_words: 1

test/services/spam_detection_service_test.rb

@@ -57,7 +57,10 @@ def setup
     tg_message = OpenStruct.new(chat: @chat, from: @from, text: pre_existing_message.message, message_id: 123)
     service = SpamDetectionService.new(tg_message)
 
-    result = service.process
+    result = nil
+    TelegramMemberFetcher.stub(:get_bot_chat_member, OpenStruct.new(status: "administrator", can_restrict_members: true)) do
+      result = service.process
+    end
 
     assert result.is_spam
     assert_equal TrainedMessage::TrainingTarget::MESSAGE_CONTENT, result.target

test/system/group_classifier_states_test.rb

@@ -14,7 +14,7 @@ class GroupClassifierStatesTest < ApplicationSystemTestCase
     visit group_classifier_states_url
     click_on "New Group Classifier"
 
-    fill_in "Group", with: @group_classifier_state.group_id
+    fill_in "Group", with: 99
     fill_in "Ham counts", with: @group_classifier_state.ham_counts
     fill_in "Spam counts", with: @group_classifier_state.spam_counts
     fill_in "Total ham messages", with: @group_classifier_state.total_ham_messages

test/system/trained_messages_test.rb

@@ -1,4 +1,6 @@
 require "application_system_test_case"
+require "ostruct"
+require "minitest/mock"
 
 class TrainedMessagesTest < ApplicationSystemTestCase
   setup do
@@ -11,18 +13,20 @@ class TrainedMessagesTest < ApplicationSystemTestCase
   end
 
   test "should create trained message" do
-    visit trained_messages_url
-    click_on "New trained message"
-
-    fill_in "Group", with: @trained_message.group_id
-    fill_in "Message", with: @trained_message.message
-    select "Spam", from: "Message type"
-    select "Message Content", from: "Training target"
-    fill_in "Sender chat", with: @trained_message.sender_chat_id
-    click_on "Create Trained message"
-
-    assert_text "Trained message was successfully created"
-    click_on "Back"
+    TelegramMemberFetcher.stub(:get_bot_chat_member, OpenStruct.new(status: "administrator", can_restrict_members: true)) do
+      visit trained_messages_url
+      click_on "New trained message"
+
+      fill_in "Group", with: @trained_message.group_id
+      fill_in "Message", with: @trained_message.message
+      select "Spam", from: "Message type"
+      select "Message Content", from: "Training target"
+      fill_in "Sender chat", with: @trained_message.sender_chat_id
+      click_on "Create Trained message"
+
+      assert_text "Trained message was successfully created"
+      click_on "Back"
+    end
   end
 
   test "should update Trained message" do