add background job to sync message type across messages if they are identical

Author: ramsayleung

app/controllers/trained_messages_controller.rb

@@ -88,6 +88,13 @@ def bulk_update
 
     messages.update_all(message_type: new_message_type_symbol, updated_at: Time.current)
 
+    # Update all messages to the same message type if they have same
+    # message hash
+    message_hashes_to_sync = messages.pluck(:message_hash).uniq
+    message_hashes_to_sync.each do |hash|
+      MessageTypeSyncJob.perform_later(hash, new_message_type_symbol)
+    end
+
     messages.each do |message|
       if message.spam? || message.ham?
         BatchProcessor.add_to_batch(

app/jobs/message_type_sync_job.rb

@@ -0,0 +1,30 @@
+class MessageTypeSyncJob < ApplicationJob
+  queue_as :low_priority
+
+  def perform(message_hash, new_message_type_symbol)
+    new_message_type = new_message_type_symbol.to_s
+
+    # 1. Update all messages with the same hash
+    new_type_value = TrainedMessage.message_types[new_message_type]
+
+    # Select only messages whose type will *actually* change to prevent unnecessary updates
+    messages_to_sync = TrainedMessage.where(message_hash: message_hash)
+                         .where.not(message_type: new_message_type)
+
+    messages_to_sync.update_all(message_type: new_type_value, updated_at: Time.current)
+
+    # 2. Trigger Retraining and Ban Checks for all updated messages
+    messages_to_sync.each do |message|
+      if message.spam? || message.ham?
+        BatchProcessor.add_to_batch(
+          "classifier_training_batch_key",
+          "ClassifierTrainerJob",
+          message,
+          {},
+          batch_size: 100,
+          batch_window: 5.minutes
+        )
+      end
+    end
+  end
+end

app/models/trained_message.rb

@@ -37,7 +37,7 @@ module Source
   after_update :retrain_classifier, if: :trainable_type_changed?
   after_create :should_ban_user, if: :trainable?
   after_update :should_ban_user, if: :trainable_type_changed?
-
+  after_update :sync_message_type_by_hash, if: :saved_change_to_message_type?
 
   def should_ban_user
     if [ GroupClassifierState::TELEGRAM_DATA_COLLECTOR_GROUP_ID, GroupClassifierState::USER_NAME_CLASSIFIER_GROUP_ID ].include? self.group_id
@@ -99,4 +99,10 @@ def trainable_type_changed?
   def set_message_hash
     self.message_hash = Digest::SHA256.hexdigest(message.to_s)
   end
+
+  def sync_message_type_by_hash
+    if spam? || ham?
+      MessageTypeSyncJob.perform_later(self.message_hash, self.message_type.to_sym)
+    end
+  end
 end

test/jobs/message_type_sync_job_test.rb

@@ -0,0 +1,7 @@
+require "test_helper"
+
+class MessageTypeSyncJobTest < ActiveJob::TestCase
+  # test "the truth" do
+  #   assert true
+  # end
+end