Skip to content

Rename finalizers to conform with best practices #117

@belgaied2

Description

@belgaied2

Describe the solution you'd like:
A log line in the harvestermachine controller shows the following:

2025-07-17T18:07:36Z	INFO	metadata.finalizers: "harvestermachine.infrastructure.cluster.x-k8s.io": prefer a domain-qualified finalizer name including a path (/) to avoid accidental conflicts with other finalizer writers	{"controller": "harvestermachine", "controllerGroup": "infrastructure.cluster.x-k8s.io", "controllerKind": "HarvesterMachine", "HarvesterMachine": {"name":"talos-hv-cp-machine-2np9z","namespace":"test-hv"}, "namespace": "test-hv", "name": "talos-hv-cp-machine-2np9z", "reconcileID": "9c6fcd1e-7b48-4c2e-b1f2-9f9fc4a8ec15", "machine": "test-hv/talos-hv-control-plane-rzcm8", "cluster": "test-hv/talos-hv"}

This suggests that the finalizer should be renamed from harvestermachine.infrastructure.cluster.x-k8s.io to harvestermachine.infrastructure.cluster.x-k8s.io/finalizer or cluster.x-k8s.io/harvestermachine.

Why do you want this feature:
For compliance with best practices and in order to remove warning from logs.

Anything else you would like to add:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions