Check Steve HTTP readiness instead of raw TCP connectivity

isPortReady() used a raw TCP connect to determine when Steve was
ready. Steve accepts TCP connections several seconds before it
finishes initializing its API controllers, so the dashboard button
was enabled too early. Make an actual HTTP request to /v1 instead,
using Steve's HTTP port to avoid certificate validation issues with
its self-signed TLS cert.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>

Author: jandubois

pkg/rancher-desktop/backend/steve.ts

@@ -1,5 +1,5 @@
 import { ChildProcess, spawn } from 'child_process';
-import net from 'net';
+import http from 'http';
 import os from 'os';
 import path from 'path';
 import { setTimeout } from 'timers/promises';
@@ -19,6 +19,7 @@ export class Steve {
 
   private isRunning: boolean;
   private httpsPort = 0;
+  private httpPort = 0;
 
   private constructor() {
     this.isRunning = false;
@@ -52,6 +53,7 @@ export class Steve {
     }
 
     this.httpsPort = httpsPort;
+    this.httpPort = httpPort;
 
     const osSpecificName = /^win/i.test(os.platform()) ? 'steve.exe' : 'steve';
     const stevePath = path.join(paths.resources, os.platform(), 'internal', osSpecificName);
@@ -115,7 +117,7 @@ export class Steve {
   }
 
   /**
-   * Wait for Steve to be ready to accept connections.
+   * Wait for Steve to be ready to serve API requests.
    */
   private async waitForReady(): Promise<void> {
     const maxAttempts = 60;
@@ -139,26 +141,31 @@ export class Steve {
   }
 
   /**
-   * Check if Steve is accepting connections on its HTTPS port.
+   * Check if Steve is serving HTTP requests. A raw TCP connect is not
+   * sufficient because Steve accepts connections before it finishes
+   * initializing its API controllers. Uses the HTTP port to avoid
+   * certificate validation issues with Steve's self-signed TLS cert.
    */
   private isPortReady(): Promise<boolean> {
     return new Promise((resolve) => {
-      const socket = new net.Socket();
-
-      socket.setTimeout(1000);
-      socket.once('connect', () => {
-        socket.destroy();
-        resolve(true);
-      });
-      socket.once('error', () => {
-        socket.destroy();
-        resolve(false);
+      const req = http.request({
+        hostname: '127.0.0.1',
+        port:     this.httpPort,
+        path:     '/v1',
+        method:   'GET',
+        timeout:  1000,
+        agent:    false,
+      }, (res) => {
+        res.resume();
+        resolve(res.statusCode !== undefined && res.statusCode < 500);
       });
-      socket.once('timeout', () => {
-        socket.destroy();
+
+      req.on('error', () => resolve(false));
+      req.on('timeout', () => {
+        req.destroy();
         resolve(false);
       });
-      socket.connect(this.httpsPort, '127.0.0.1');
+      req.end();
     });
   }