Skip to content

Commit 8c5f174

Browse files
STAC-23392: address pull request review comments v2
1 parent 465f8d0 commit 8c5f174

File tree

3 files changed

+21
-39
lines changed

3 files changed

+21
-39
lines changed

docs/latest/modules/en/pages/k8s-suse-rancher-prime.adoc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,9 @@ Create a `values.yaml` file with your configuration:
255255
[source,yaml]
256256
----
257257
global:
258-
# Required: Set image registry for {ss-rancher-product-short-name} images
259-
imageRegistry: "registry.rancher.com"
258+
# Optional: Override image registry (defaults to registry.rancher.com)
259+
# Only needed for air-gapped environments or custom registries
260+
# imageRegistry: "your-private-registry.example.com"
260261
261262
suseObservability:
262263
# Required: Your {ss-rancher-product-short-name} license key

docs/latest/modules/en/pages/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Also, make sure to follow the air-gapped installation instructions whenever thos
3939

4040
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#_create_namespace[Create the namespace where SUSE Observability will be installed]
4141
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#create-values-yaml[Create `values.yaml` configuration file]
42-
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#_set_up_a_storage_class[Set up a storage class]
42+
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#_configure_storage_class_optional[Configure storage class (Optional)]
4343
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#_deploy_suse_observability_with_helm[Deploy SUSE Observability with Helm]
4444
. xref:/setup/install-stackstate/kubernetes_openshift/kubernetes_install.adoc#_access_the_suse_observability_ui[Access the SUSE Observability UI]
4545

@@ -73,11 +73,12 @@ Create a `values.yaml` file with the `global.suseObservability` configuration st
7373
[source,yaml]
7474
----
7575
global:
76-
# Required: Set image registry for SUSE Observability images
77-
imageRegistry: "registry.rancher.com"
76+
# Optional: Override image registry (defaults to registry.rancher.com)
77+
# Only needed for air-gapped environments or custom registries
78+
# imageRegistry: "your-private-registry.example.com"
7879
79-
# Required: Storage class for persistent volumes
80-
storageClass: "local-path" # Rancher's local-path recommended if available
80+
# Optional: Override storage class (uses cluster default if not set)
81+
# storageClass: "your-storage-class"
8182
8283
suseObservability:
8384
# Required: Your SUSE Observability license key
@@ -208,22 +209,21 @@ The {ss-rancher-product-short-name} Values chart generates affinity configuratio
208209
--
209210
====
210211

211-
=== Set up a storage class
212+
=== Configure storage class (Optional)
212213

213-
You need to set up a storage class. Rancher's `local-path` is recommended if available, but SUSE Storage is also supported.
214+
{ss-rancher-product-short-name} uses the cluster's default storage class if not specified. You can optionally override this by setting `global.storageClass` in your `values.yaml` file.
214215

215216
[tabs]
216217
====
217218
Recommended method::
218219
+
219220
--
220-
Add the storage class to your `values.yaml` file under `global.storageClass`:
221+
If you need to use a specific storage class, add it to your `values.yaml` file under `global.storageClass`:
221222
222223
[source,yaml]
223224
----
224225
global:
225-
imageRegistry: "registry.rancher.com"
226-
storageClass: "local-path" # Your storage class name
226+
storageClass: "your-storage-class" # e.g., "local-path" for Rancher local-path provisioner
227227
suseObservability:
228228
# ... other configuration
229229
----
@@ -237,8 +237,7 @@ Edit the file `$VALUES_DIR/suse-observability-values/templates/baseConfig_values
237237
----
238238
# Source suse-observability-values/templates/baseConfig_values.yaml
239239
global:
240-
imageRegistry: "registry.rancher.com"
241-
storageClass: "local-path" # New configuration line, the rest remains the same
240+
storageClass: "your-storage-class" # Optional: override default storage class
242241
----
243242
--
244243
====

docs/latest/modules/en/pages/setup/upgrade-stackstate/migrate-to-global-mode.adoc

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -456,36 +456,18 @@ helm get values suse-observability -n suse-observability
456456

457457
== Generate a bcrypt password hash
458458

459-
The `adminPassword` must be a bcrypt hash. Generate one using:
459+
If migrating from the legacy method, your existing `adminPassword` is already a bcrypt hash and can be used directly.
460460

461-
[tabs]
462-
====
463-
htpasswd (Linux/macOS)::
464-
+
465-
--
466-
[,text]
467-
----
468-
htpasswd -bnBC 10 "" "your-password" | tr -d ':\n'
469-
----
470-
--
461+
If you need to generate a new bcrypt hash:
471462

472-
Python::
473-
+
474-
--
475-
[,text]
463+
[,bash]
476464
----
477-
python3 -c "import bcrypt; print(bcrypt.hashpw(b'your-password', bcrypt.gensalt(10)).decode())"
465+
htpasswd -bnBC 10 "" "your-password" | tr -d ':\n'
478466
----
479-
--
480467

481-
Docker::
482-
+
483-
--
484-
[,text]
485-
----
486-
docker run --rm httpd:alpine htpasswd -bnBC 10 "" "your-password" | tr -d ':\n'
487-
----
488-
--
468+
[NOTE]
469+
====
470+
Future versions will also support plain text passwords.
489471
====
490472

491473
== Troubleshooting

0 commit comments

Comments
 (0)