Return associated pod data for deployments, etc., as part of the payload (#1017)

* Generate assocation blocks for deployments with their related pods.

Also:

- Add `metadata.state.{error,message,transitioning`} to `_v1_Pod_fields` table
  (We already index `metadata.state.name` for all GVKs

- Return an array called `metadata.associations` for each GVK we care about.

- Right now there will be at most one entry:
  `{ GVK: podGVK, data: <array of info on each pod's metadata.state associated with the deployment> }`

- The integration tests rely on the core rancher deployments, which all have associated pods.

- No need to add "fake" deployments.

- Write a more generic db-client routine to read rows containing n string values.

* We need to also show jobs associated with cron jobs.

- One problem is that pods are related to their parent objects via

`metadata.relationships[toType=pod].selector`

but jobs are related to parent `batch.cronjobs` via

`metadata.relationships[toType=batch.job].toId`

I wrote separate selection functions for each form.

Also:
 Drop ReadStrings2 in favor of 'ReadStringsN(..., 2)'

* Misc changes:

- If a yaml load fails modify the error to give the input file name.

- s/podname/childname/ and add integration tests for deployment/pod relationships

* Add the includeAssociatedData query param.

* Ensure user has access to the associated resource.

- Fix a unit-test to ensure the user has access to the child schema.

- Demote access denial to associated data to a trace log.

* This test often fails in CI, so add debug statements to help diagnose why.

Author: ericpromislow

pkg/sqlcache/db/client.go

@@ -55,7 +55,7 @@ type Client interface {
 	QueryForRows(ctx context.Context, stmt Stmt, params ...any) (Rows, error)
 	ReadObjects(rows Rows, typ reflect.Type) ([]any, error)
 	ReadStrings(rows Rows) ([]string, error)
-	ReadStrings2(rows Rows) ([][]string, error)
+	ReadStringsN(rows Rows, numColumns int) ([][]string, error)
 	ReadInt(rows Rows) (int, error)
 	ReadStringIntString(rows Rows) ([][]string, error)
 	Upsert(tx TxClient, stmt Stmt, key string, obj SerializedObject) error
@@ -323,20 +323,22 @@ func (c *client) ReadStrings(rows Rows) ([]string, error) {
 	return result, nil
 }
 
-// ReadStrings2 scans the given rows into pairs of strings, and then returns the strings as a slice.
-func (c *client) ReadStrings2(rows Rows) ([][]string, error) {
+// ReadStringIntString scans the given rows into (string, int, string) tuples, and then returns a slice of them.
+func (c *client) ReadStringIntString(rows Rows) ([][]string, error) {
 	c.connLock.RLock()
 	defer c.connLock.RUnlock()
 
 	var result [][]string
 	for rows.Next() {
-		var key1, key2 string
-		err := rows.Scan(&key1, &key2)
+		var val1 string
+		var val2 int
+		var val3 string
+		err := rows.Scan(&val1, &val2, &val3)
 		if err != nil {
 			return nil, closeRowsOnError(rows, err)
 		}
 
-		result = append(result, []string{key1, key2})
+		result = append(result, []string{val1, strconv.Itoa(val2), val3})
 	}
 	err := rows.Err()
 	if err != nil {
@@ -351,22 +353,25 @@ func (c *client) ReadStrings2(rows Rows) ([][]string, error) {
 	return result, nil
 }
 
-// ReadStringIntString scans the given rows into (string, string, string) tuples, and then returns a slice of them.
-func (c *client) ReadStringIntString(rows Rows) ([][]string, error) {
+// ReadStringsN scans the given rows into string-slices of the specified number of columns
+func (c *client) ReadStringsN(rows Rows, numColumns int) ([][]string, error) {
 	c.connLock.RLock()
 	defer c.connLock.RUnlock()
 
 	var result [][]string
+	stringPointers := make([]any, numColumns)
 	for rows.Next() {
-		var val1 string
-		var val2 int
-		var val3 string
-		err := rows.Scan(&val1, &val2, &val3)
+		// stringList needs be reinitialized on each iteration or all the final data in
+		// the `result` array will be the last row!
+		stringList := make([]string, numColumns)
+		for i := range stringList {
+			stringPointers[i] = &stringList[i]
+		}
+		err := rows.Scan(stringPointers...)
 		if err != nil {
 			return nil, closeRowsOnError(rows, err)
 		}
-
-		result = append(result, []string{val1, strconv.Itoa(val2), val3})
+		result = append(result, stringList)
 	}
 	err := rows.Err()
 	if err != nil {

pkg/sqlcache/informer/db_mocks_test.go

@@ -12,6 +12,7 @@ import (
 	"time"
 
 	"github.com/rancher/apiserver/pkg/types"
+	"github.com/rancher/steve/pkg/accesscontrol"
 	"github.com/rancher/steve/pkg/sqlcache/db"
 	"github.com/rancher/steve/pkg/sqlcache/partition"
 	"github.com/rancher/steve/pkg/sqlcache/sqltypes"
@@ -66,6 +67,7 @@ func (f *WatchFilter) matches(obj metav1.Object) bool {
 }
 
 type ByOptionsLister interface {
+	AugmentList(ctx context.Context, list *unstructured.UnstructuredList, childGVK schema.GroupVersionKind, childSchemaName string, useSelectors bool, accessList accesscontrol.AccessListByVerb) error
 	ListByOptions(ctx context.Context, lo *sqltypes.ListOptions, partitions []partition.Partition, namespace string) (*unstructured.UnstructuredList, int, *types.APISummary, string, error)
 	Watch(ctx context.Context, options WatchOptions, eventsCh chan<- watch.Event) error
 	GetLatestResourceVersion() []string
@@ -179,6 +181,10 @@ func (i *Informer) RunWithContext(ctx context.Context) {
 	wg.Wait()
 }
 
+func (i *Informer) AugmentList(ctx context.Context, list *unstructured.UnstructuredList, childGVK schema.GroupVersionKind, childSchemaName string, useSelectors bool, accessList accesscontrol.AccessListByVerb) error {
+	return i.ByOptionsLister.AugmentList(ctx, list, childGVK, childSchemaName, useSelectors, accessList)
+}
+
 // ListByOptions returns objects according to the specified list options and partitions.
 // Specifically:
 //   - an unstructured list of resources belonging to any of the specified partitions