Skip to content

Commit 5616b9d

Browse files
Merge pull request #1918 from anmazzotti/e2e_add_docker_spec_name
fix: Use CAPIProvider's name to select resources
2 parents bdf5ee9 + d9318c9 commit 5616b9d

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

internal/provider/wrangler.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,17 @@ func providerDeploymentRestart(ctx context.Context, cl client.Client, provider *
459459
}
460460

461461
func getSelector(provider *turtlesv1.CAPIProvider) ([]client.ListOption, error) {
462-
matchingLabels := []string{
463-
provider.Spec.Type.ToName() + provider.Spec.Name,
464-
provider.Spec.Name, // ex. "fleet"
462+
var matchingLabels []string
463+
if provider.Spec.Name != "" {
464+
matchingLabels = []string{
465+
provider.Spec.Type.ToName() + provider.Spec.Name,
466+
provider.Spec.Name, // ex. "fleet"
467+
}
468+
} else { // support for CAPIProvider's name used as CAPIProvider.spec.name
469+
matchingLabels = []string{
470+
provider.Spec.Type.ToName() + provider.GetName(),
471+
provider.GetName(),
472+
}
465473
}
466474

467475
requirement, err := labels.NewRequirement(CAPIProviderLabel, selection.In, matchingLabels)

test/e2e/data/capi-operator/capi-providers.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
name: docker
1111
namespace: capd-system
1212
spec:
13+
name: docker
1314
type: infrastructure
1415
---
1516
apiVersion: v1

0 commit comments

Comments
 (0)