Skip to content

Commit 8c15cfa

Browse files
committed
ci: use docker image for chart-testing cli
Signed-off-by: Andrea Mazzotti <[email protected]>
1 parent 331837b commit 8c15cfa

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

.github/workflows/test_chart.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,6 @@ jobs:
3232
with:
3333
version: v3.14.3
3434

35-
- uses: actions/setup-python@v6
36-
with:
37-
python-version: '3.9'
38-
check-latest: true
39-
40-
- name: Set up chart-testing
41-
uses: helm/[email protected]
42-
with:
43-
version: v3.9.0
44-
4535
- name: setupGo
4636
uses: actions/[email protected]
4737
with:
@@ -54,7 +44,7 @@ jobs:
5444
run: make release-chart
5545

5646
- name: Run chart-testing (lint)
57-
run: ct lint --validate-maintainers=false --charts out/charts/rancher-turtles/
47+
run: make test-chart
5848

5949
- name: Install kind
6050
run: |

Makefile

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ GOLANGCI_LINT_PKG := github.com/golangci/golangci-lint/v2/cmd/golangci-lint
167167
NOTES_BIN := notes
168168
NOTES := $(abspath $(TOOLS_BIN_DIR)/$(NOTES_BIN))
169169

170+
CHART_TESTING_VER := v3.14.0
171+
170172
# Registry / images
171173
TAG ?= dev
172174
ARCH ?= linux/$(shell go env GOARCH)
@@ -537,7 +539,7 @@ $(HELM): ## Put helm into tools folder.
537539

538540
$(CLUSTERCTL): $(TOOLS_BIN_DIR) ## Download and install clusterctl
539541
curl --retry $(CURL_RETRIES) -fsSL -o $(CLUSTERCTL) https://github.com/kubernetes-sigs/cluster-api/releases/download/$(CLUSTERCTL_VER)/clusterctl-linux-amd64
540-
chmod +x $(CLUSTERCTL)
542+
chmod +x $(CLUSTERCTL)
541543

542544
## --------------------------------------
543545
## Release
@@ -584,6 +586,15 @@ release-chart: $(HELM) $(NOTES) build-chart verify-gen
584586
$(NOTES) --repository $(REPO) -add-kubernetes-version-support=false -from=tags/$(PREVIOUS_TAG) -release=$(RELEASE_TAG) -branch=main > $(CHART_RELEASE_DIR)/RELEASE_NOTES.md
585587
$(HELM) package $(CHART_RELEASE_DIR) --app-version=$(HELM_CHART_TAG) --version=$(HELM_CHART_TAG) --destination=$(CHART_PACKAGE_DIR)
586588

589+
.PHONY: test-chart
590+
test-chart: build-chart
591+
docker run --rm -v $(shell pwd):/charts --workdir /charts quay.io/helmpack/chart-testing:$(CHART_TESTING_VER) ct lint --validate-maintainers=false --charts $(CHART_RELEASE_DIR)
592+
593+
.PHONY: test-providers-chart
594+
test-providers-chart: build-providers-chart
595+
docker run --rm -v $(shell pwd):/charts --workdir /charts quay.io/helmpack/chart-testing:$(CHART_TESTING_VER) ct lint --validate-maintainers=false --charts $(PROVIDERS_CHART_RELEASE_DIR)
596+
597+
587598
## --------------------------------------
588599
## Rancher charts testing
589600
## --------------------------------------

0 commit comments

Comments
 (0)