Further decouple grunt-postmark from mailmason.

Per @derekrushforth's comments on ActiveCampaign/grunt-postmark#3.

[This](ActiveCampaign/grunt-postmark#3 (comment)) will break things for folks who are already using these changes (@gcoombe and @jmas) as we're now looking for `lowerCamel` variable names instead of `Title` cased ones. Just means a quick find/replace for `Name`/`name, `Subject`/`subject`, etc.

I've internally changed the implementation of `postmark-templates-upload` to support in-memory `htmlBody` and `textBody` as well as lazy loaded paths `htmlSrc` and `textSrc` as @hybernaut originally had it. I didn't actually notice how far my changes had deviated from the default options for the `postmark-templates-upload` task when I filed the PR, but I actually like the idea of loading the template files instead of expecting them to be passed along as task data.

Author: randytarampi

Gruntfile.js

@@ -317,22 +317,23 @@ module.exports = function(grunt) {
       options: {
         src: [path.email_src],
         dist: path.dist,
-        outputFile: '<%= config.templates.output_file || config.templates.file %>'
+        file: '<%= config.templates.file %>'
       }
     },
 
-    'postmark-templates-output': {
+    'postmark-templates-upload': {
       options: {
-        outputFile: '<%= config.templates.output_file || config.templates.file %>',
-        cleanOutput: '<%= config.templates.clean_output %>'
+        ephemeralUploadResultsProperty: '<%= config.templates && config.templates.ephemeralUploadResultsProperty %>'
       }
     },
 
-    'postmark-templates-upload': grunt.file.readJSON(
-      config.templates.output_file
-        ? config.templates.output_file
-        : config.templates.file
-    )
+    'postmark-templates-output': {
+      options: {
+        outputFile: '<%= config.templates && config.templates.output_file || config.templates && config.templates.file %>',
+        cleanOutput: '<%= config.templates && config.templates.clean_output %>',
+        ephemeralUploadResultsProperty: '<%= config.templates && config.templates.ephemeralUploadResultsProperty %>'
+      }
+    },
   });
 
 
@@ -355,7 +356,7 @@ module.exports = function(grunt) {
   grunt.registerTask('flood', ['testBuild', 'postmark:flood']);
 
   // Upload
-  grunt.registerTask('upload', ['default', 'postmark-templates-generate', 'postmark-templates-reload-templates', 'postmark-templates']);
+  grunt.registerTask('upload', ['default', 'postmark-templates-generate', 'postmark-templates']);
 
   // Before sending tests via Postmark, ensure that test builds with inlined CSS are generated
   grunt.registerTask('testBuild', ['default', 'copy:testTemplates', 'premailer:html']);

example_config.json

@@ -52,6 +52,8 @@
     "overwrite": true
   },
   "templates": {
-    "file": "templates.json"
+    "file": "templates.json",
+    "cleanOutput": true,
+    "ephemeralUploadResultsProperty": "postmark-templates-upload-results"
   }
 }

previews.html

@@ -69,7 +69,7 @@
           var list_item = document.createElement('li')
           var anchor = document.createElement('a')
           anchor.setAttribute('href', '#' + key)
-          anchor.appendChild(document.createTextNode(templates[key]['Name'] || templates[key]['name']))
+          anchor.appendChild(document.createTextNode(templates[key]['name']))
           list_item.appendChild(anchor)
           list_item.appendChild(document.createTextNode(' - ' + templates[key]['description']))
           toc.appendChild(list_item)
@@ -85,7 +85,7 @@
           guide_link.setAttribute('target', '_blank')
           guide_link.setAttribute('rel', 'noopener noreferrer')
           guide_link.appendChild(document.createTextNode('📖 View Best Practices Guide'))
-          heading.appendChild(document.createTextNode(templates[key]['Name'] || templates[key]['name']))
+          heading.appendChild(document.createTextNode(templates[key]['name']))
           heading.setAttribute('id', key)
           description.appendChild(document.createTextNode(templates[key]['description']))
           description.appendChild(guide_link)

tasks/grunt-postmark-templates-generate.js

@@ -12,24 +12,24 @@ module.exports = function (grunt) {
 
     var options = this.options();
     var templatePaths = grunt.file.expand(options.src);
-    var templateObjects = grunt.file.readJSON(grunt.config.get('config.templates.file'));
+    var templateObjects = grunt.file.readJSON(options.file);
 
     templatePaths.map(function (templatePath) {
       try {
         var templateFile = yaml.loadFront(grunt.file.read(templatePath));
         var templateName = path.basename(templatePath, '.hbs');
         var templateContents = {
-          Name: templateObjects[templateName] && templateObjects[templateName].name || templateName,
-          HtmlBody: grunt.file.read(path.join(options.dist, templateName + '.html')),
-          TextBody: grunt.file.read(path.join(options.dist, templateName + '.txt'))
+          name: templateObjects[templateName] && templateObjects[templateName].name || templateName,
+          htmlSrc: path.join(options.dist, templateName + '.html'),
+          textSrc: path.join(options.dist, templateName + '.txt')
         };
 
         if (templateFile.name) {
-          templateContents.Name = templateFile.name;
+          templateContents.name = templateFile.name;
         }
 
         if (templateFile.subject) {
-          templateContents.Subject = templateFile.subject;
+          templateContents.subject = templateFile.subject;
         }
 
         if (!templateObjects[templateName]) {
@@ -45,6 +45,6 @@ module.exports = function (grunt) {
       }
     });
 
-    grunt.file.write(grunt.config.get('config.templates.file'), JSON.stringify(templateObjects, null, 2));
+    grunt.config('postmark-templates-upload', templateObjects);
   });
 };