Skip to content

Commit 45872ed

Browse files
elminsonrap2hpoutre
authored andcommitted
comment conf file (#160)
* Creating a array that content all the patterns used in the class, this allow if in the feature we want to create a new featured that include patterns we cant add this for a best readeability (some patterns get really complicated * Modifying all the sugestion from rap2hpoutre in the PR comments * Log Location customisable #139 * changing storage_path() to ->storage_path * Fixing error Cannot use object of type Rap2hpoutre\LaravelLogViewer\Pattern as array + changing array to not static + creating new function getPattern * fixing Codacy/PR Quality Review * Adding .idea to gitignore file + adding comments to config file Merge remote-tracking branch 'upstream/master' # Conflicts: # src/Rap2hpoutre/LaravelLogViewer/LaravelLogViewer.php # src/Rap2hpoutre/LaravelLogViewer/Pattern.php
1 parent 3790892 commit 45872ed

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
/vendor
22
composer.lock
3+
/.idea

src/Rap2hpoutre/LaravelLogViewer/Pattern.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,4 @@ public function getPattern($pattern, $position = null)
4444
return $this->patterns[$pattern];
4545

4646
}
47-
4847
}

src/config/logviewer.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
<?php
22

33
return [
4+
/*
5+
|--------------------------------------------------------------------------
6+
| Pattern and storage path settings
7+
|--------------------------------------------------------------------------
8+
|
9+
| The env key for pattern and storage path with a default value
10+
|
11+
*/
412
'pattern' => env('LOGVIEWER_PATTERN', '*.log'),
513
'storage_path' => env('LOGVIEWER_STORAGE_PATH', 'logs'),
614
];

0 commit comments

Comments
 (0)