Rich content breaks things

[alex8bitw]

When sending an email with rich content (html+js+css) we get:

BadRequest: {"errors":[{"field":"body","help":"invalid JSON","message":"invalid request body"}]}

[rapatao]

Can you share a request to simulate this error?

[alex8bitw]

I don't have the specific request, but this is the code that generates the email: https://github.com/bitwarden/server/blob/4a1212095053bb93e936038a71f44b01ebbb3c36/src/Core/Services/Implementations/SendGridMailDeliveryService.cs#L11

That creates a multi-part encoded email with 2 parts of:
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0

and

Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=utf-8
Mime-Version: 1.0

[rapatao]

I was reading the SendGrid v3 API, and it doesn't have any reference for supporting multipart content, only JSON.

https://www.twilio.com/docs/sendgrid/api-reference/mail-send/mail-send

Looking at their docs, I found references to multipart support on the v2, which isn't supported. https://www.twilio.com/docs/sendgrid/v2-api/mail#raw-http-dump

Anyway, I couldn't confirm if the C# SendGrid library is using the v3 or other API version, if I checked it correctly (I'm not so used to C# code), the code isn't defining any version when defining the request path: https://github.com/sendgrid/sendgrid-csharp/blob/4a315350e910ef10c6579ca5291ed7f82ad9d376/src/SendGrid/BaseClient.cs#L237

I didn't find any reference about multipart support in the v3 endpoints, which is currently the only version supported by the project. I also don't have any use case that could help simulate it and "fix" that problem.

If you'd like to, you could create a PR adding support to it, I can review it as fast as possible, merging and creating a release with that feature you need.

[alex8bitw]

According to the Sendgrid API doc for C#: https://github.com/sendgrid/sendgrid-csharp
It defaults to v3 of the API for version 9.29.3 which the project is using: https://github.com/bitwarden/server/blob/69b7600eabde42b9cf3acb943ecff4e832404162/src/Core/Core.csproj#L48

I'll be happy to test it out if you put in a PR!

[rapatao]

This is strange because in the SendGrid doc, there isn't any reference to supporting multipart request, only JSON.

About implementing it, I don't have any use case for it, don't have any request example to see how complex would be nor much spare time to investigate and work on it.

So, as I said before, you are welcome to contribute to the project.

Since you also can't contribute, let's wait for someone that could support you, implementing the support you need.